You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/07/14 02:55:37 UTC
[kudu-CR] KUDU-2671 check for duplicate columns in hash schema when adding range
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18728
Change subject: KUDU-2671 check for duplicate columns in hash schema when adding range
......................................................................
KUDU-2671 check for duplicate columns in hash schema when adding range
This patch adds validation for the range-specific hash schema when
adding a new range partition. Without this patch, invalid requests
to add a range partitions with duplicate columns across hash dimensions
of the custom hash schema would be accepted, but tablets could not be
created, resulting in timed-out IsAlterTableDone() RPC. The patch also
contains new test scenarios for both the C++ and the Java clients,
making sure the corresponding error is reported back to the client.
I verified that the new scenarios failed as expected if commenting out
the newly added schema validation code.
Change-Id: Iefe6a97028ae12585ac5496ac8608448ffacd95e
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M src/kudu/client/flex_partitioning_client-test.cc
M src/kudu/common/partition.h
M src/kudu/master/catalog_manager.cc
4 files changed, 169 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/18728/1
--
To view, visit http://gerrit.cloudera.org:8080/18728
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iefe6a97028ae12585ac5496ac8608448ffacd95e
Gerrit-Change-Number: 18728
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] KUDU-2671 check for duplicate columns in hash schema when adding range
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18728 )
Change subject: KUDU-2671 check for duplicate columns in hash schema when adding range
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18728
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefe6a97028ae12585ac5496ac8608448ffacd95e
Gerrit-Change-Number: 18728
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 06:05:32 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 check for duplicate columns in hash schema when adding range
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18728 )
Change subject: KUDU-2671 check for duplicate columns in hash schema when adding range
......................................................................
Patch Set 4: Verified+1
unrelated test failure in TimestampAdvancementITest.TestUpgradeFromOlderCorruptedData
--
To view, visit http://gerrit.cloudera.org:8080/18728
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefe6a97028ae12585ac5496ac8608448ffacd95e
Gerrit-Change-Number: 18728
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 14:33:37 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 check for duplicate columns in hash schema when adding range
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Tidy Bot, Kurt Deschler, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18728
to look at the new patch set (#4).
Change subject: KUDU-2671 check for duplicate columns in hash schema when adding range
......................................................................
KUDU-2671 check for duplicate columns in hash schema when adding range
This patch adds validation for range-specific hash schemas when
adding new range partitions. Without this patch, invalid requests
to add range partitions with duplicate columns across dimensions
of the custom hash schema would be accepted, but tablets could not be
created, resulting in timed-out IsAlterTableDone() RPC. The patch also
contains new test scenarios for both C++ and Java Kudu clients, making
sure the corresponding error is reported back to the client. I verified
that the new test scenarios failed as expected if commenting out
the newly added hash schema validation code.
This patch also fixes a few typos in test scenarios from master-test.cc
since the new verification code exposed those mistakes.
Change-Id: Iefe6a97028ae12585ac5496ac8608448ffacd95e
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M src/kudu/client/flex_partitioning_client-test.cc
M src/kudu/common/partition.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
5 files changed, 283 insertions(+), 117 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/18728/4
--
To view, visit http://gerrit.cloudera.org:8080/18728
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iefe6a97028ae12585ac5496ac8608448ffacd95e
Gerrit-Change-Number: 18728
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-2671 check for duplicate columns in hash schema when adding range
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Tidy Bot, Kurt Deschler, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18728
to look at the new patch set (#2).
Change subject: KUDU-2671 check for duplicate columns in hash schema when adding range
......................................................................
KUDU-2671 check for duplicate columns in hash schema when adding range
This patch adds validation for the range-specific hash schema when
adding a new range partition. Without this patch, invalid requests
to add a range partitions with duplicate columns across hash dimensions
of the custom hash schema would be accepted, but tablets could not be
created, resulting in timed-out IsAlterTableDone() RPC. The patch also
contains new test scenarios for both the C++ and the Java clients,
making sure the corresponding error is reported back to the client.
I verified that the new scenarios failed as expected if commenting out
the newly added schema validation code.
This patch also fixes a few typos in test scenarios from master-test.cc
since the new verification coded exposed those mistakes.
Change-Id: Iefe6a97028ae12585ac5496ac8608448ffacd95e
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M src/kudu/client/flex_partitioning_client-test.cc
M src/kudu/common/partition.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
5 files changed, 288 insertions(+), 117 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/18728/2
--
To view, visit http://gerrit.cloudera.org:8080/18728
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iefe6a97028ae12585ac5496ac8608448ffacd95e
Gerrit-Change-Number: 18728
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-2671 check for duplicate columns in hash schema when adding range
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-2671 check for duplicate columns in hash schema when adding range
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18728
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Iefe6a97028ae12585ac5496ac8608448ffacd95e
Gerrit-Change-Number: 18728
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] KUDU-2671 check for duplicate columns in hash schema when adding range
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Tidy Bot, Kurt Deschler, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18728
to look at the new patch set (#3).
Change subject: KUDU-2671 check for duplicate columns in hash schema when adding range
......................................................................
KUDU-2671 check for duplicate columns in hash schema when adding range
This patch adds validation for range-specific hash schemas when
adding new range partitions. Without this patch, invalid requests
to add range partitions with duplicate columns across dimensions
of the custom hash schema would be accepted, but tablets could not be
created, resulting in timed-out IsAlterTableDone() RPC. The patch also
contains new test scenarios for both C++ and Java Kudu clients, making
sure the corresponding error is reported back to the client. I verified
that the new test scenarios failed as expected if commenting out
the newly added hash schema validation code.
This patch also fixes a few typos in test scenarios from master-test.cc
since the new verification code exposed those mistakes.
Change-Id: Iefe6a97028ae12585ac5496ac8608448ffacd95e
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M src/kudu/client/flex_partitioning_client-test.cc
M src/kudu/common/partition.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
5 files changed, 288 insertions(+), 117 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/18728/3
--
To view, visit http://gerrit.cloudera.org:8080/18728
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iefe6a97028ae12585ac5496ac8608448ffacd95e
Gerrit-Change-Number: 18728
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-2671 check for duplicate columns in hash schema when adding range
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18728 )
Change subject: KUDU-2671 check for duplicate columns in hash schema when adding range
......................................................................
KUDU-2671 check for duplicate columns in hash schema when adding range
This patch adds validation for range-specific hash schemas when
adding new range partitions. Without this patch, invalid requests
to add range partitions with duplicate columns across dimensions
of the custom hash schema would be accepted, but tablets could not be
created, resulting in timed-out IsAlterTableDone() RPC. The patch also
contains new test scenarios for both C++ and Java Kudu clients, making
sure the corresponding error is reported back to the client. I verified
that the new test scenarios failed as expected if commenting out
the newly added hash schema validation code.
This patch also fixes a few typos in test scenarios from master-test.cc
since the new verification code exposed those mistakes.
Change-Id: Iefe6a97028ae12585ac5496ac8608448ffacd95e
Reviewed-on: http://gerrit.cloudera.org:8080/18728
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M src/kudu/client/flex_partitioning_client-test.cc
M src/kudu/common/partition.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
5 files changed, 283 insertions(+), 117 deletions(-)
Approvals:
Mahesh Reddy: Looks good to me, but someone else must approve
Alexey Serbin: Looks good to me, approved; Verified
Abhishek Chennaka: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/18728
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iefe6a97028ae12585ac5496ac8608448ffacd95e
Gerrit-Change-Number: 18728
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] KUDU-2671 check for duplicate columns in hash schema when adding range
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18728 )
Change subject: KUDU-2671 check for duplicate columns in hash schema when adding range
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18728
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefe6a97028ae12585ac5496ac8608448ffacd95e
Gerrit-Change-Number: 18728
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Fri, 15 Jul 2022 18:39:04 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 check for duplicate columns in hash schema when adding range
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18728 )
Change subject: KUDU-2671 check for duplicate columns in hash schema when adding range
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18728
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefe6a97028ae12585ac5496ac8608448ffacd95e
Gerrit-Change-Number: 18728
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 14:45:01 +0000
Gerrit-HasComments: No