You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@spamassassin.apache.org on 2026/09/15 21:07:06 UTC
[Bug 8421] New: Hidden undiscussed dependencies in "Handler" features.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8421
Bug ID: 8421
Summary: Hidden undiscussed dependencies in "Handler" features.
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Hardware: PC
OS: Mac OS X
Status: NEW
Severity: normal
Priority: P2
Component: Building & Packaging
Assignee: dev@spamassassin.apache.org
Reporter: billcole@apache.org
Target Milestone: Undefined
The new handler functionality and its tests require the tesseract package and
one test requires something called "heif-convert" which code comments claim is
in "libheif" but which is not installed by the libheif package on FreeBSD.
Apparently at some point libheif changed the "real name" of that tool to
"heif-dec" and now the build adds a symlink for the "old" name, an addition
which the FreeBSD packager removes, perhaps errantly as the patchfile removes a
whole conditional checking for Windows.
I do not recall (and cannot find) any discussion of adding these optional(?)
dependencies. They are not tested for or mentioned in the output of
Makefile.PL. The are not mentioned in INSTALL. Tesseract is mentioned in
UPGRADE and build/announcements/4.0.3.txt, libheif and heif-convert are not.
Both libheif and tesseract have substantial recursive dependencies which users
should be made aware of prior to upgrading.
Proposal:
1. Update SA to use 'heif-dec' (the cononical name) instead of 'heif-convert'
(the symlink name on Linux which is a duplicated file on Windows.)
2. Add mention of the new dependencies to INSTALL, expand mention in UPGRADE
and 4.0.3.txt to include libheif.
3. Add check for tesseract and libheif to Makefile.PL
Because this involves documentation of new features, I believe it should block
release.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8421] Hidden undiscussed dependencies in "Handler" features.
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8421
Giovanni Bechis <gi...@paclan.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |giovanni@paclan.it
--- Comment #2 from Giovanni Bechis <gi...@paclan.it> ---
+1 on the patch, I agree that we can rename the configuration parameter without
adding backwards compatibility, just mention it in the commit message.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8421] Hidden undiscussed dependencies in "Handler" features.
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8421
Bill Cole <bi...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |billcole@apache.org
--- Comment #3 from Bill Cole <bi...@apache.org> ---
+1 to commit the patch. No need to alias the config parameter, as it was never
released with the old name.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8421] Hidden undiscussed dependencies in "Handler" features.
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8421
Giovanni Bechis <gi...@paclan.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |4.0.3
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8421] Hidden undiscussed dependencies in "Handler" features.
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8421
Kent Oyer <ke...@mxguardian.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kent@mxguardian.net
--- Comment #1 from Kent Oyer <ke...@mxguardian.net> ---
Created attachment 6086
--> https://bz.apache.org/SpamAssassin/attachment.cgi?id=6086&action=edit
add dependency info
Please see the attached patch. Note that this changes the configuration
parameter name from 'image_heif_convert_path' to 'image_heif_dec_path'. I can
add 'image_heif_convert_path' as an alias for backward compatibility but this
is a new feature in 4.0.3 so it's never been part of a release. Renaming the
config parameter only affects people on trunk who might have enabled the Image
handler since it was added ~2 months ago.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8421] Hidden undiscussed dependencies in "Handler" features.
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8421
Giovanni Bechis <gi...@paclan.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #5 from Giovanni Bechis <gi...@paclan.it> ---
fixed in r1938327
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8421] Hidden undiscussed dependencies in "Handler" features.
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8421
--- Comment #4 from Kent Oyer <ke...@mxguardian.net> ---
Sending INSTALL
Sending UPGRADE
Sending lib/Mail/SpamAssassin/Handler/Image.pm
Sending lib/Mail/SpamAssassin/Util/DependencyInfo.pm
Sending rules/v403.pre
Sending t/handler_image_heic.t
Transmitting file data ......done
Committing transaction...
Committed revision 1938327.
--
You are receiving this mail because:
You are the assignee for the bug.