[GitHub] sdedic commented on a change in pull request #976: [NETBEANS-1481] Fix handling of module fragments (regression 9.0)

[GitBox <gi...@apache.org>]

sdedic commented on a change in pull request #976: [NETBEANS-1481] Fix handling of module fragments (regression 9.0)
URL: https://github.com/apache/incubator-netbeans/pull/976#discussion_r226930797
 
 

 ##########
 File path: platform/o.n.bootstrap/src/org/netbeans/ModuleManager.java
 ##########
 @@ -1678,10 +1678,12 @@ public boolean hasToEnableCompatModules(Set<Module> modules) throws IllegalArgum
         }
         return false;
     }
-    
+
     private void maybeAddToEnableList(Set<Module> willEnable, Set<Module> mightEnable, Module m, boolean okToFail) {
-        if (! missingDependencies(m).isEmpty()) {
-            assert okToFail : "Module " + m + " had unexpected problems: " + missingDependencies(m) + " (willEnable: " + willEnable + " mightEnable: " + mightEnable + ")";
+        if (!missingDependencies(m).isEmpty()) {
+            if (!okToFail) {
 
 Review comment:
   This seems to change the behaviour for regular modules as well, not just for fragments. Was it intended ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists