You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/07/08 20:50:03 UTC
[PR] Revert "remove `derive(Copy)` from `Operator` (#11132)" [datafusion]
alamb opened a new pull request, #11341:
URL: https://github.com/apache/datafusion/pull/11341
This reverts commit b468ba788310d5dcd6ea4549f0d5b0f215ea49c9.
## Which issue does this PR close?
## Rationale for this change
We originally made this change in https://github.com/apache/datafusion/pull/11132 as we thought it was necessary for user defined sql extensions (https://github.com/apache/datafusion/issues/11207) but we eventually went with a different approach (specifically https://github.com/apache/datafusion/pull/11180 from @jayzhan211 )
Thus I think this change is unnecessary and since it is a breaking API change it will cause unnecessary issues on upgrade for users.
Let's revert it
## What changes are included in this PR?
This reverts commit b468ba788310d5dcd6ea4549f0d5b0f215ea49c9 / https://github.com/apache/datafusion/pull/11132
## Are these changes tested?
Yes, by CI / clippy
## Are there any user-facing changes?
Revert what I think is an uncessary API change
cc @samuelcolvin and @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Revert "remove `derive(Copy)` from `Operator` (#11132)" [datafusion]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #11341:
URL: https://github.com/apache/datafusion/pull/11341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org