You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm-dev@maven.apache.org by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org> on 2005/11/11 15:59:06 UTC

[jira] Created: (SCM-72) Remove tagbase usage and use insted mecanism use in update command

Remove tagbase usage and use insted mecanism use in update command
------------------------------------------------------------------

         Key: SCM-72
         URL: http://jira.codehaus.org/browse/SCM-72
     Project: Maven SCM
        Type: Task
  Components: maven-scm-provider-svn  
    Versions: 1.0-beta-1    
    Reporter: Emmanuel Venisse


David Hawkins, do you want work on it?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (SCM-72) Remove tagbase usage and use insted mecanism use in update command

Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SCM-72?page=comments#action_50714 ] 

Emmanuel Venisse commented on SCM-72:
-------------------------------------

After a discussion with David, we won't remove tagbase. We'll use it if it's specified but by default, we'll consider that user use a standard repository layout (trunk/, tags/, branches)

If user use a standard layout, tags directory is automatically discover.
And the other feature added in update command is the support of standard svn revision specifiers (HEAD, BASE, COMMITTED, PREV) and revision number

The last feature is if tag != null or it isn't a revision number, we use the svn switch command instead of update


> Remove tagbase usage and use insted mecanism use in update command
> ------------------------------------------------------------------
>
>          Key: SCM-72
>          URL: http://jira.codehaus.org/browse/SCM-72
>      Project: Maven SCM
>         Type: Task
>   Components: maven-scm-provider-svn
>     Versions: 1.0-beta-1
>     Reporter: Emmanuel Venisse

>
>
> David Hawkins, do you want work on it?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (SCM-72) Remove tagbase usage and use insted mecanism use in update command

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SCM-72?page=comments#action_50710 ] 

John Casey commented on SCM-72:
-------------------------------

what's the mechanism used in the update command? What changes are necessary for the release mojo to support this new approach?

> Remove tagbase usage and use insted mecanism use in update command
> ------------------------------------------------------------------
>
>          Key: SCM-72
>          URL: http://jira.codehaus.org/browse/SCM-72
>      Project: Maven SCM
>         Type: Task
>   Components: maven-scm-provider-svn
>     Versions: 1.0-beta-1
>     Reporter: Emmanuel Venisse

>
>
> David Hawkins, do you want work on it?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (SCM-72) Remove tagbase usage and use insted mecanism use in update command

Posted by "David Hawkins (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SCM-72?page=all ]

David Hawkins updated SCM-72:
-----------------------------

    Attachment: SCM-72-maven-scm-test.patch
                SCM-72-maven.scm-provider-svn.patch

Added automatic tag resolution to SvnCheckoutCommand, SvnChangeLogCommand, and SvnTagCommand.

On the SvnChangeLogCommand command, I changed the date format specified in the command line. 
The original format looked like: svn log -v -r "{2003/09/10 GMT}:{2003/10/10 GMT}"
But this format was not legal in svn version 1.2.3 on cygwin, linux, or windows.  I am not sure if a previous version supported this date format, but the current does not.
The new date format looks like: svn log -v -r "{2003-09-10 00:00:00 +0000}:{2003-10-10 00:00:00 +0000}"
It is now specifying the time along with the date. The api allows  a user to pass a date, so we should probably use the time in the date as well.
I also changed ScmTestCase.getDate() to support passing time values so I could test the changelog command creation.  

As far as SvnDiffCommand goes, I didn't add branch/tag resolution to it because the api specifies a "startRevision" and "endRevision".  While it might be useful to be able to support tag/branch diffs, the api only specifies revisions.  This is something that can always be added at a later date if deemed necessary.

It also seems odd to me that the StatusMojo doesn't actually print anything out.  It has a StatusScmResult with a list of changed files, but only checks that the result was successful.  Maybe I don't understand the intended use of the action, but it basically throws away the result without ever doing anything with it.

> Remove tagbase usage and use insted mecanism use in update command
> ------------------------------------------------------------------
>
>          Key: SCM-72
>          URL: http://jira.codehaus.org/browse/SCM-72
>      Project: Maven SCM
>         Type: Task
>   Components: maven-scm-provider-svn
>     Versions: 1.0-beta-1
>     Reporter: Emmanuel Venisse
>  Attachments: SCM-72-maven-scm-test.patch, SCM-72-maven.scm-provider-svn.patch
>
>
> David Hawkins, do you want work on it?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (SCM-72) Remove tagbase usage and use insted mecanism use in update command

Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SCM-72?page=all ]
     
Emmanuel Venisse closed SCM-72:
-------------------------------

      Assign To: Emmanuel Venisse
     Resolution: Fixed
    Fix Version: 1.0-beta-1

Applied, thanks.

For your two point on status mojo and diff command, you can file an issue for each

> Remove tagbase usage and use insted mecanism use in update command
> ------------------------------------------------------------------
>
>          Key: SCM-72
>          URL: http://jira.codehaus.org/browse/SCM-72
>      Project: Maven SCM
>         Type: Task
>   Components: maven-scm-provider-svn
>     Versions: 1.0-beta-1
>     Reporter: Emmanuel Venisse
>     Assignee: Emmanuel Venisse
>      Fix For: 1.0-beta-1
>  Attachments: SCM-72-maven-scm-test.patch, SCM-72-maven.scm-provider-svn.patch
>
>
> David Hawkins, do you want work on it?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira