You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/03/26 13:13:26 UTC
[GitHub] [cordova-plugin-device] timbru31 opened a new pull request #121:
build: ignores tests folder for npm tarball
timbru31 opened a new pull request #121: build: ignores tests folder for npm tarball
URL: https://github.com/apache/cordova-plugin-device/pull/121
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
### Description
<!-- Describe your changes in detail -->
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-device] timbru31 merged pull request #121:
chore(npm): improve ignore list
Posted by GitBox <gi...@apache.org>.
timbru31 merged pull request #121: chore(npm): improve ignore list
URL: https://github.com/apache/cordova-plugin-device/pull/121
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-device] timbru31 commented on issue #121: build:
ignores tests folder for npm tarball
Posted by GitBox <gi...@apache.org>.
timbru31 commented on issue #121: build: ignores tests folder for npm tarball
URL: https://github.com/apache/cordova-plugin-device/pull/121#issuecomment-604426713
Testing can be done with `npm pack --dry-run`:
```
npm notice
npm notice 📦 cordova-plugin-device@2.0.4-dev
npm notice === Tarball Contents ===
npm notice 11.4kB LICENSE
npm notice 163B NOTICE
npm notice 957B src/ios/CDVDevice.h
npm notice 932B src/osx/CDVDevice.h
npm notice 5.4kB src/android/Device.java
npm notice 3.0kB www/device.js
npm notice 2.8kB src/browser/DeviceProxy.js
npm notice 4.4kB src/windows/DeviceProxy.js
--> SEE HERE npm notice 4.5kB tests/tests.js
npm notice 1.3kB package.json
--> SEE HERE npm notice 260B tests/package.json
npm notice 3.3kB src/ios/CDVDevice.m
npm notice 3.8kB src/osx/CDVDevice.m
npm notice 1.4kB CONTRIBUTING.md
npm notice 7.3kB README.md
npm notice 11.7kB RELEASENOTES.md
npm notice 1.4kB types/index.d.ts
npm notice 3.2kB plugin.xml
--> SEE HERE npm notice 1.2kB tests/plugin.xml
npm notice === Tarball Details ===
npm notice name: cordova-plugin-device
npm notice version: 2.0.4-dev
npm notice filename: cordova-plugin-device-2.0.4-dev.tgz
npm notice package size: 18.0 kB
npm notice unpacked size: 68.4 kB
npm notice shasum: 230a362b1c11848e96b2434ca5f0f8326be099ea
npm notice integrity: sha512-vb64LVNUOulYO[...]5zcqnltjI3ZCQ==
npm notice total files: 21
npm notice
cordova-plugin-device-2.0.4-dev.tgz
```
Obviously, we shouldn't ship the `tests/` folder with npm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org