You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/04 22:39:57 UTC

[GitHub] [airflow] ephraimbuddy commented on pull request #19367: Do not send DAGs with null DagModel.max_active_runs to the scheduler

ephraimbuddy commented on pull request #19367:
URL: https://github.com/apache/airflow/pull/19367#issuecomment-961486413


   > This feels like only a partial fix.
   > 
   > If a DAG is currently working (and has max_active_runs) and _then_ the file is updated and now has an error, the DAG will still be scheduled, but it probably shouldn't be.
   > 
   > To do that without needing to join against ImportError perhaps we need to add a new column to DAG -- we have `is_active` which is close, but setting that to false hides it from the UI which isn't the behaviour we want here.
   
   I have updated it and it looks good. Thanks for the review!!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org