You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/04/21 23:34:40 UTC
[GitHub] [trafficcontrol] dpham692 opened a new issue #4655: Internal Server Error for incorrect startdate query param in /GET deliveryservice_stats
dpham692 opened a new issue #4655:
URL: https://github.com/apache/trafficcontrol/issues/4655
<!--
************ STOP!! ************
If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
-->
<!--
- For *SUPPORT QUESTIONS*, use the
[Traffic Control slack channels](https://traffic-control-cdn.slack.com) or [Traffic Control mailing lists](http://trafficcontrol.apache.org/mailing_lists/).
- Before submitting, please **SEARCH GITHUB** for a similar issue or PR. -->
## I'm submitting a ...
<!-- (check all that apply with "[x]") -->
<!--- security vulnerability (STOP!! - see above)-->
- [x] bug report
- [ ] new feature / enhancement request
- [ ] improvement request (usability, performance, tech debt, etc.)
- [ ] other <!--(Please do not submit support requests here - see above)-->
## Traffic Control components affected ...
<!-- (check all that apply with "[x]") -->
- [ ] CDN in a Box
- [ ] Documentation
- [ ] Grove
- [ ] Traffic Control Client
- [ ] Traffic Monitor
- [x] Traffic Ops
- [ ] Traffic Ops ORT
- [ ] Traffic Portal
- [ ] Traffic Router
- [ ] Traffic Stats
- [ ] Traffic Vault
- [ ] unknown
## Current behavior:
<!-- Describe how the bug manifests / how the current features are insufficient. -->
Perform a /GET deliveryservice_stats with incorrect startDate param input.
For example: `api/2.0/deliveryservice_stats?deliveryServiceName=client-steering-geoordered-mkga&deliveryService=9999999&startDate=1&endDate=2020-07-22T17:56:00.000Z&metricType=tps_total`
It will return a 500 Internal Server Error
## Expected / new behavior:
<!-- Describe what the behavior would be without the bug / how the feature would improve Traffic Control -->
Should return 400 Bad Request
## Minimal reproduction of the problem with instructions:
<!--
If the current behavior is a bug or you can illustrate your feature request better with an example,
please provide the *STEPS TO REPRODUCE* and include the applicable TC version.
-->
## Anything else:
<!-- e.g. stacktraces, related issues, suggestions how to fix -->
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on issue #4655: Internal Server Error for incorrect startdate query param in /GET deliveryservice_stats
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #4655:
URL: https://github.com/apache/trafficcontrol/issues/4655#issuecomment-617494938
I actually think I know what this is. And I think it's unavoidable. Details to follow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] dpham692 commented on issue #4655: Internal Server Error for incorrect startdate query param in /GET deliveryservice_stats
Posted by GitBox <gi...@apache.org>.
dpham692 commented on issue #4655:
URL: https://github.com/apache/trafficcontrol/issues/4655#issuecomment-617472302
No there is none.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on issue #4655: Internal Server Error for incorrect startdate query param in /GET deliveryservice_stats
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #4655:
URL: https://github.com/apache/trafficcontrol/issues/4655#issuecomment-619306483
This was most likely caused by a timeout. Your startDate parameter is not invalid, so 400 would be incorrect in any case (except perhaps that you've provided two differing identities for a DS). When trying to reproduce this error, I found this in the logs:
```
ERROR: api.go:180: 2020-04-25T02:26:03.780490149Z: 172.21.0.1:33552 Getting summary response from Influx: unable to decode json: received status code 200 err: context deadline exceeded (Client.Timeout or context cancellation while reading body)
```
Which is pretty much what I expected. When there's a problem communicating with Influx the only proper response is a 500 error with no details.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on issue #4655: Internal Server Error for incorrect startdate query param in /GET deliveryservice_stats
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #4655:
URL: https://github.com/apache/trafficcontrol/issues/4655#issuecomment-624211970
I'd say so; it's been 11 days so I think if there was anything to say in response it would've been said by now. But I'll follow up with him in dms.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on issue #4655: Internal Server Error for incorrect startdate query param in /GET deliveryservice_stats
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #4655:
URL: https://github.com/apache/trafficcontrol/issues/4655#issuecomment-617470694
Do you see anything in the logs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on issue #4655: Internal Server Error for incorrect startdate query param in /GET deliveryservice_stats
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4655:
URL: https://github.com/apache/trafficcontrol/issues/4655#issuecomment-624187761
so can this be closed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org