[jira] [Commented] (HBASE-3968) HLog Pretty Printer

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-3968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058729#comment-13058729 ] 

stack commented on HBASE-3968:
------------------------------

Patch looks great.  A few questions:

You do toStringBinary.  Is this going to be ok inside in the middle of a JSON output?  Does toStringBinary do sufficient escaping such that parse of the emitted JSON is still possible or when you do JSONObject, does that do the necessary escaping?

What do you mean by Put action here:

'+            out.println("  Put action:");'

That everything is a 'put'?

You are missing a license on HLogPrettyPrinter.java (but thats minor, I can fix on commit).

It looks great.

Does it work?  Do you have examples you could paste into the issue to demo its actually working?

Good on you Riley.



> HLog Pretty Printer
> -------------------
>
>                 Key: HBASE-3968
>                 URL: https://issues.apache.org/jira/browse/HBASE-3968
>             Project: HBase
>          Issue Type: New Feature
>          Components: io, regionserver, util
>            Reporter: Nicolas Spiegelberg
>            Assignee: Riley Patterson
>            Priority: Minor
>              Labels: hbase
>         Attachments: HBASE-3968.patch
>
>
> We currently have a rudimentary way to print HLog data, but it is limited and currently prints key-only information. We need extend this functionality, similar to how we developed HFile's pretty printer. Ideas for functionality:
> - filter by sequence_id
> - filter by row / region
> - option to print values in addition to key info
> - option to print output in JSON format (so scripts can easily parse for analysis)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira