You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by al...@apache.org on 2017/11/13 20:37:45 UTC

mesos git commit: Fixed flaky RescindRevocableOfferWithIncreasedRevocable test.

Repository: mesos
Updated Branches:
  refs/heads/master 5925b4244 -> 1c94458e3


Fixed flaky RescindRevocableOfferWithIncreasedRevocable test.

This is addendum to review https://reviews.apache.org/r/55893/.
The loop that merges outstanding offers can miss some because it
removes the items from the collection it iterates over.

Review: https://reviews.apache.org/r/63710/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/1c94458e
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/1c94458e
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/1c94458e

Branch: refs/heads/master
Commit: 1c94458e33933b983b7b369bfcbeb4e847caeef1
Parents: 5925b42
Author: Alexander Rukletsov <ru...@gmail.com>
Authored: Mon Nov 13 21:37:23 2017 +0100
Committer: Alexander Rukletsov <al...@apache.org>
Committed: Mon Nov 13 21:37:23 2017 +0100

----------------------------------------------------------------------
 src/tests/oversubscription_tests.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/1c94458e/src/tests/oversubscription_tests.cpp
----------------------------------------------------------------------
diff --git a/src/tests/oversubscription_tests.cpp b/src/tests/oversubscription_tests.cpp
index d262bbe..2f403d3 100644
--- a/src/tests/oversubscription_tests.cpp
+++ b/src/tests/oversubscription_tests.cpp
@@ -547,7 +547,7 @@ TEST_F(OversubscriptionTest, RescindRevocableOfferWithIncreasedRevocable)
 
   // The total offered resources after the latest estimate.
   Resources resources3;
-  for (size_t i = 0; i < offers.size(); i++) {
+  while (offers.size() != 0) {
     resources3 += offers.get()->resources();
   }