[GitHub] [spark] wangyum commented on a change in pull request #24371: [SPARK-27176][FOLLOW-UP][SQL] Shade Parquet to sql/core

[GitBox <gi...@apache.org>]

wangyum commented on a change in pull request #24371: [SPARK-27176][FOLLOW-UP][SQL] Shade Parquet to sql/core
URL: https://github.com/apache/spark/pull/24371#discussion_r275631979
 
 

 ##########
 File path: assembly/pom.xml
 ##########
 @@ -31,6 +31,7 @@
   <packaging>pom</packaging>
 
   <properties>
+    <parquet.deps.scope>provided</parquet.deps.scope>
 
 Review comment:
   At least `make-distribution.sh` needs this property.
   If we don't add this property, `parquet-*-1.10.1.jar` will be in the `${SPARK_HOME}/jars` directory.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org