You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tamas Mate (Code Review)" <ge...@cloudera.org> on 2019/07/12 17:18:02 UTC

[Impala-ASF-CR] IMPALA-8750: Fix profile observability tests 

Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13851


Change subject: IMPALA-8750: Fix profile observability tests
......................................................................

IMPALA-8750: Fix profile observability tests

IMPALA-8443 adds a test 'test_query_profile_contains_query_compilation_events'
which can fail because there are two parts of the 'Query Compilation' events
that can change based on the build environment.
1) Whether the metadata is cached or not before the test starts.
2) Whether 'lineage_event_log_dir' is configured on the cluster.

This change covers these scenarios by splitting the tests into sepearate ones
where the catalog cache is pre-evicted/pre-loaded and taking into consideration
the current cluster configuration.

Change-Id: I65a1e81870e808f0e261f8a6097efdcc6903912a
---
M tests/common/impala_service.py
M tests/query_test/test_observability.py
2 files changed, 55 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/13851/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I65a1e81870e808f0e261f8a6097efdcc6903912a
Gerrit-Change-Number: 13851
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>

[Impala-ASF-CR] IMPALA-8750: Fix profile observability tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13851 )

Change subject: IMPALA-8750: Fix profile observability tests
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/3898/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65a1e81870e808f0e261f8a6097efdcc6903912a
Gerrit-Change-Number: 13851
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jul 2019 14:59:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8750: Fix profile observability tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13851 )

Change subject: IMPALA-8750: Fix profile observability tests
......................................................................

IMPALA-8750: Fix profile observability tests

IMPALA-8443 adds a test 'test_query_profile_contains_query_compilation_events'
which can fail because there are two parts of the 'Query Compilation' events
that can change based on the build environment.
1) Whether the metadata is cached or not before the test starts.
2) Whether 'lineage_event_log_dir' is configured on the cluster.

This change covers these scenarios by splitting the tests into sepearate ones
where the catalog cache is pre-evicted/pre-loaded and taking into consideration
the current cluster configuration.

Change-Id: I65a1e81870e808f0e261f8a6097efdcc6903912a
Reviewed-on: http://gerrit.cloudera.org:8080/13851
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/common/impala_service.py
M tests/query_test/test_observability.py
2 files changed, 57 insertions(+), 6 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I65a1e81870e808f0e261f8a6097efdcc6903912a
Gerrit-Change-Number: 13851
Gerrit-PatchSet: 7
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>

[Impala-ASF-CR] IMPALA-8750: Fix profile observability tests

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13851 )

Change subject: IMPALA-8750: Fix profile observability tests
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65a1e81870e808f0e261f8a6097efdcc6903912a
Gerrit-Change-Number: 13851
Gerrit-PatchSet: 5
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jul 2019 05:45:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8750: Fix profile observability tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13851 )

Change subject: IMPALA-8750: Fix profile observability tests
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/3901/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65a1e81870e808f0e261f8a6097efdcc6903912a
Gerrit-Change-Number: 13851
Gerrit-PatchSet: 5
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jul 2019 16:47:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8750: Fix profile observability tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13851 )

Change subject: IMPALA-8750: Fix profile observability tests
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4596/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/13851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65a1e81870e808f0e261f8a6097efdcc6903912a
Gerrit-Change-Number: 13851
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jul 2019 18:12:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8750: Fix profile observability tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13851 )

Change subject: IMPALA-8750: Fix profile observability tests
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13851/4/tests/common/impala_service.py
File tests/common/impala_service.py:

http://gerrit.cloudera.org:8080/#/c/13851/4/tests/common/impala_service.py@88
PS4, Line 88: f
flake8: E501 line too long (96 > 90 characters)



-- 
To view, visit http://gerrit.cloudera.org:8080/13851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65a1e81870e808f0e261f8a6097efdcc6903912a
Gerrit-Change-Number: 13851
Gerrit-PatchSet: 4
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jul 2019 15:34:25 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8750: Fix profile observability tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13851 )

Change subject: IMPALA-8750: Fix profile observability tests
......................................................................


Patch Set 6: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65a1e81870e808f0e261f8a6097efdcc6903912a
Gerrit-Change-Number: 13851
Gerrit-PatchSet: 6
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jul 2019 11:57:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8750: Fix profile observability tests

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13851 )

Change subject: IMPALA-8750: Fix profile observability tests
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/13851/1/tests/common/impala_service.py
File tests/common/impala_service.py:

http://gerrit.cloudera.org:8080/#/c/13851/1/tests/common/impala_service.py@90
PS1, Line 90: 'flags'
nit: it's better to not mix quotes. For consistency, maybe use "" instead.


http://gerrit.cloudera.org:8080/#/c/13851/1/tests/common/impala_service.py@90
PS1, Line 90:     for var in varz.get('flags'):
            :       if var["name"] == flag:
            :         return var["current"]
what should this method return when varz.get("flags") is empty?


http://gerrit.cloudera.org:8080/#/c/13851/1/tests/query_test/test_observability.py
File tests/query_test/test_observability.py:

http://gerrit.cloudera.org:8080/#/c/13851/1/tests/query_test/test_observability.py@326
PS1, Line 326: 'lineage_event_log_dir'
nit: use double quotes for consistency


http://gerrit.cloudera.org:8080/#/c/13851/1/tests/query_test/test_observability.py@327
PS1, Line 327: print (lineage_event_log_dir_value)
remove debug information



-- 
To view, visit http://gerrit.cloudera.org:8080/13851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65a1e81870e808f0e261f8a6097efdcc6903912a
Gerrit-Change-Number: 13851
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Jul 2019 04:50:12 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8750: Fix profile observability tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13851 )

Change subject: IMPALA-8750: Fix profile observability tests
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65a1e81870e808f0e261f8a6097efdcc6903912a
Gerrit-Change-Number: 13851
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jul 2019 23:53:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8750: Fix profile observability tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13851 )

Change subject: IMPALA-8750: Fix profile observability tests
......................................................................


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4609/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65a1e81870e808f0e261f8a6097efdcc6903912a
Gerrit-Change-Number: 13851
Gerrit-PatchSet: 6
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jul 2019 05:46:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8750: Fix profile observability tests

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/13851 )

Change subject: IMPALA-8750: Fix profile observability tests
......................................................................


Patch Set 1:

Hi Fredy, I added you as reviewer if you don't mind because you are familiar with the previous change.


-- 
To view, visit http://gerrit.cloudera.org:8080/13851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65a1e81870e808f0e261f8a6097efdcc6903912a
Gerrit-Change-Number: 13851
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jul 2019 17:20:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8750: Fix profile observability tests

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Hello Fredy Wijaya, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13851

to look at the new patch set (#5).

Change subject: IMPALA-8750: Fix profile observability tests
......................................................................

IMPALA-8750: Fix profile observability tests

IMPALA-8443 adds a test 'test_query_profile_contains_query_compilation_events'
which can fail because there are two parts of the 'Query Compilation' events
that can change based on the build environment.
1) Whether the metadata is cached or not before the test starts.
2) Whether 'lineage_event_log_dir' is configured on the cluster.

This change covers these scenarios by splitting the tests into sepearate ones
where the catalog cache is pre-evicted/pre-loaded and taking into consideration
the current cluster configuration.

Change-Id: I65a1e81870e808f0e261f8a6097efdcc6903912a
---
M tests/common/impala_service.py
M tests/query_test/test_observability.py
2 files changed, 57 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/13851/5
-- 
To view, visit http://gerrit.cloudera.org:8080/13851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I65a1e81870e808f0e261f8a6097efdcc6903912a
Gerrit-Change-Number: 13851
Gerrit-PatchSet: 5
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>

[Impala-ASF-CR] IMPALA-8750: Fix profile observability tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13851 )

Change subject: IMPALA-8750: Fix profile observability tests
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65a1e81870e808f0e261f8a6097efdcc6903912a
Gerrit-Change-Number: 13851
Gerrit-PatchSet: 6
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jul 2019 05:46:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8750: Fix profile observability tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13851 )

Change subject: IMPALA-8750: Fix profile observability tests
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/3900/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65a1e81870e808f0e261f8a6097efdcc6903912a
Gerrit-Change-Number: 13851
Gerrit-PatchSet: 4
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jul 2019 16:13:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8750: Fix profile observability tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13851 )

Change subject: IMPALA-8750: Fix profile observability tests
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/3870/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65a1e81870e808f0e261f8a6097efdcc6903912a
Gerrit-Change-Number: 13851
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jul 2019 17:58:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8750: Fix profile observability tests

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/13851 )

Change subject: IMPALA-8750: Fix profile observability tests
......................................................................

IMPALA-8750: Fix profile observability tests

IMPALA-8443 adds a test 'test_query_profile_contains_query_compilation_events'
which can fail because there are two parts of the 'Query Compilation' events
that can change based on the build environment.
1) Whether the metadata is cached or not before the test starts.
2) Whether 'lineage_event_log_dir' is configured on the cluster.

This change covers these scenarios by splitting the tests into sepearate ones
where the catalog cache is pre-evicted/pre-loaded and taking into consideration
the current cluster configuration.

Change-Id: I65a1e81870e808f0e261f8a6097efdcc6903912a
---
M tests/common/impala_service.py
M tests/query_test/test_observability.py
2 files changed, 56 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/13851/3
-- 
To view, visit http://gerrit.cloudera.org:8080/13851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I65a1e81870e808f0e261f8a6097efdcc6903912a
Gerrit-Change-Number: 13851
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>

[Impala-ASF-CR] IMPALA-8750: Fix profile observability tests

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Hello Fredy Wijaya, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13851

to look at the new patch set (#4).

Change subject: IMPALA-8750: Fix profile observability tests
......................................................................

IMPALA-8750: Fix profile observability tests

IMPALA-8443 adds a test 'test_query_profile_contains_query_compilation_events'
which can fail because there are two parts of the 'Query Compilation' events
that can change based on the build environment.
1) Whether the metadata is cached or not before the test starts.
2) Whether 'lineage_event_log_dir' is configured on the cluster.

This change covers these scenarios by splitting the tests into sepearate ones
where the catalog cache is pre-evicted/pre-loaded and taking into consideration
the current cluster configuration.

Change-Id: I65a1e81870e808f0e261f8a6097efdcc6903912a
---
M tests/common/impala_service.py
M tests/query_test/test_observability.py
2 files changed, 57 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/13851/4
-- 
To view, visit http://gerrit.cloudera.org:8080/13851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I65a1e81870e808f0e261f8a6097efdcc6903912a
Gerrit-Change-Number: 13851
Gerrit-PatchSet: 4
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>