[GitHub] [superset] dpgaspar commented on pull request #16618: feat: feature flag configurable custom backend

[GitBox <gi...@apache.org>]

dpgaspar commented on pull request #16618:
URL: https://github.com/apache/superset/pull/16618#issuecomment-916000367


   > I think this feature flag backend would also need to be able to evaluate all feature flags to send via bootstrap [here](https://github.com/apache/superset/blob/master/superset/views/base.py#L367). Otherwise, you'd still need to define a `GET_FEATURE_FLAGS_FUNC` to get the proper values to the frontend, which seems like it would defeat the purpose of having a custom backend.
   > 
   > Update:
   > Disregard, I see now that this can also be achieved with the `COMMON_BOOTSTRAP_OVERRIDES_FUNC` config. It may be good to make a note that it is required to do this to ensure flags are consistent between bootstrap and the custom backend
   
   Actually that's a good point, I made a refactor on this PR to directly override `is_feature_enabled` it's simpler and ended up being simpler to integrate on our side. No need to make the note on the config, since `get_feature_flags` maps all flags to `is_feature_enabled` when the override is set.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org