You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2024/01/30 17:50:47 UTC
[PR] chore: Remove useless contractor parameters in doc tests. [incubator-pekko]
He-Pin opened a new pull request, #1086:
URL: https://github.com/apache/incubator-pekko/pull/1086
Motivation:
Fix the nightly build on Scala 3.3
https://github.com/apache/incubator-pekko/actions/runs/7714027653/job/21025328188
I tested it locally, the tests passed.
I Have no idea why it works on Scala 2.13, as there is an additional argument, and should fail as Scala 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Remove useless contractor parameters in doc tests. [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #1086:
URL: https://github.com/apache/incubator-pekko/pull/1086#discussion_r1471702298
##########
docs/src/test/scala/docs/actor/ActorDocSpec.scala:
##########
@@ -345,7 +345,7 @@ class ActorDocSpec extends PekkoSpec("""
}
Review Comment:
There is no argument needed for `FirstActor`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Remove useless contractor parameters in doc tests. [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin closed pull request #1086: chore: Remove useless contractor parameters in doc tests.
URL: https://github.com/apache/incubator-pekko/pull/1086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Remove useless contractor parameters in doc tests. [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1086:
URL: https://github.com/apache/incubator-pekko/pull/1086#issuecomment-1917680905
I think this is a dotty issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org