You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by sa...@apache.org on 2018/09/27 22:21:49 UTC

[pulsar] branch master updated: Python Functions support topic pattern, so removing this check (#2668)

This is an automated email from the ASF dual-hosted git repository.

sanjeevrk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new edd4bed  Python Functions support topic pattern, so removing this check (#2668)
edd4bed is described below

commit edd4bedb975cdcb95f1343efcc26cf82af24d422
Author: Sanjeev Kulkarni <sa...@gmail.com>
AuthorDate: Thu Sep 27 15:21:44 2018 -0700

    Python Functions support topic pattern, so removing this check (#2668)
---
 .../java/org/apache/pulsar/functions/runtime/RuntimeSpawner.java    | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeSpawner.java b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeSpawner.java
index 030a5a7..adb4578 100644
--- a/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeSpawner.java
+++ b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeSpawner.java
@@ -68,12 +68,6 @@ public class RuntimeSpawner implements AutoCloseable {
         log.info("{}/{}/{}-{} RuntimeSpawner starting function", details.getTenant(), details.getNamespace(),
                 details.getName(), this.instanceConfig.getInstanceId());
 
-        if (instanceConfig.getFunctionDetails().getRuntime() == PYTHON
-                && instanceConfig.getFunctionDetails().getSource() != null
-                && StringUtils.isNotBlank(instanceConfig.getFunctionDetails().getSource().getTopicsPattern())) {
-            throw new IllegalArgumentException("topics-pattern is not supported for python function");
-        }
-
         runtime = runtimeFactory.createContainer(this.instanceConfig, codeFile,
                 instanceLivenessCheckFreqMs * 1000);
         runtime.start();