You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/10 07:07:09 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #4316: Handle listProjects API to list projects with user as Project Admin when listAll=true
Pearl1594 opened a new pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316
## Description
1. When listAll is true, listProjects API doesn't list projects that have users as members
2. Added defensive checks to overcome NPEs
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## How Has This Been Tested?
This has been verified using the cmk and UI
There exists 7 projects:
```
MariaDB [cloud]> select name, account_id, user_id, created, removed from project_view;
MariaDB [cloud]> select name, account_id, user_id, created, removed from project_view where removed is NULL;
+--------------+------------+---------+---------------------+---------+
| name | account_id | user_id | created | removed |
+--------------+------------+---------+---------------------+---------+
| Project2 | 4 | NULL | 2020-09-09 10:08:52 | NULL |
| Project2 | 5 | 6 | 2020-09-09 10:08:52 | NULL |
| p3 | 2 | NULL | 2020-09-09 11:43:50 | NULL |
| p3 | 5 | 5 | 2020-09-09 11:43:50 | NULL |
| Project1 | 2 | NULL | 2020-09-09 12:36:03 | NULL |
| Project1 | 5 | 5 | 2020-09-09 12:36:03 | NULL |
| p1 | 2 | 2 | 2020-09-09 13:16:11 | NULL |
| p1 | 5 | 5 | 2020-09-09 13:16:11 | NULL |
| d1 | 12 | 8 | 2020-09-09 13:21:38 | NULL |
| p1 | 2 | 2 | 2020-09-09 13:16:11 | NULL |
| p1 | 5 | 5 | 2020-09-09 13:16:11 | NULL |
| p4 | 15 | 10 | 2020-09-10 05:54:44 | NULL |
| p41useradmin | 17 | 12 | 2020-09-10 06:23:43 | NULL |
| Project1 | 2 | NULL | 2020-09-09 12:36:03 | NULL |
| Project1 | 5 | 5 | 2020-09-09 12:36:03 | NULL |
+--------------+------------+---------+---------------------+---------+
```
Before fix:
```
(localcloud) SBCM5> > list projects filter=account,owner,name,id, listall=true
{
"count": 2,
"project": [
{
"id": "cab2a46a-8250-4825-85ff-e18e7275eb18",
"name": "p3",
"owner": [
{
"account": "admin"
}
]
},
{
"id": "f0e64573-3483-4e4c-8164-c92e9efda80f",
"name": "Project2",
"owner": [
{
"account": "ACSUser"
}
]
}
]
}
```
With fix:
```
(localcloud) SBCM5> > list projects filter=account,owner,name,id, listall=true
{
"count": 7,
"project": [
{
"id": "0f4a6c4f-a95e-4ea2-b840-e16eedf1085a",
"name": "p41useradmin",
"owner": [
{
"account": "u4",
"user": "u41",
"userid": "9d523792-a777-45c2-8b34-84052b8d4b34"
}
]
},
{
"id": "352b9a95-cc6e-412f-ad1a-7671eaebfdff",
"name": "p4",
"owner": [
{
"account": "u3",
"user": "u3",
"userid": "41d2a5e2-f45f-479b-bc2b-3c911d2b7b46"
}
]
},
{
"id": "02b5bc7b-a1e7-4e77-860e-99fd5fb30ec3",
"name": "d1",
"owner": [
{
"account": "dom1",
"user": "dom1",
"userid": "a534379c-804d-4a45-bf09-73e784adacb0"
}
]
},
{
"id": "7ab34cd7-2403-477a-a3cf-9d03c517345c",
"name": "p1",
"owner": [
{
"account": "admin",
"user": "admin",
"userid": "e125c80a-eebf-11ea-ba61-1e006a013aee"
},
{
"account": "user1",
"user": "user1",
"userid": "705136fe-2c09-4031-873f-835ee3dfad02"
}
]
},
{
"id": "f5884fbe-9ce1-4315-9a76-c1564d13dac0",
"name": "Project1",
"owner": [
{
"account": "admin"
},
{
"account": "user1",
"user": "user1",
"userid": "705136fe-2c09-4031-873f-835ee3dfad02"
}
]
},
{
"id": "cab2a46a-8250-4825-85ff-e18e7275eb18",
"name": "p3",
"owner": [
{
"account": "admin"
}
]
},
{
"id": "f0e64573-3483-4e4c-8164-c92e9efda80f",
"name": "Project2",
"owner": [
{
"account": "ACSUser"
}
]
}
]
}
```
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-690866765
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4316: Handle listProjects API to list projects with user as Project Admin when listAll=true
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-690064060
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-690874064
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-690866610
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-690883746
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1955
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4316: Handle listProjects API to list projects with user as Project Admin when listAll=true
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-690036200
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4316: Handle listProjects API to list projects with user as Project Admin when listAll=true
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-690036451
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-690857576
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-692537574
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-690884292
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-690857576
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-692559841
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2009
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-690864985
Packaging result: ✔centos7 ✔centos8 ✖debian. JID-1953
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-690857260
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-693839743
Lgtm, test failures unrelated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-693233039
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-691390426
<b>Trillian test result (tid-2718)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 74705 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4316-t2718-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_pvlan.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 81 look OK, 4 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 253.21 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 338.73 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 501.95 | test_privategw_acl.py
test_create_pvlan_network | `Error` | 0.20 | test_pvlan.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 541.83 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 3813.82 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 3972.65 | test_vpc_redundant.py
test_hostha_kvm_host_fencing | `Error` | 191.82 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-690805830
<b>Trillian test result (tid-2717)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 58171 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4316-t2717-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_domain_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_nested_virtualization.py
Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_portforwardingrules.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 54 look OK, 31 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py
test_deploy_vm_from_iso | `Error` | 0.00 | test_deploy_vm_iso.py
ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | test_internal_lb.py
ContextSuite context=TestDeployVmWithVariedPlanners>:setup | `Error` | 0.00 | test_deploy_vms_with_varied_deploymentplanners.py
test_01_1_create_iso_with_checksum_sha1_negative | `Error` | 66.71 | test_iso.py
test_01_create_iso_with_checksum_sha1 | `Error` | 65.59 | test_iso.py
test_01_create_iso_with_checksum_sha1 | `Error` | 66.70 | test_iso.py
test_02_1_create_iso_with_checksum_sha256_negative | `Error` | 66.86 | test_iso.py
test_02_create_iso_with_checksum_sha256 | `Error` | 65.61 | test_iso.py
test_02_create_iso_with_checksum_sha256 | `Error` | 66.74 | test_iso.py
test_03_1_create_iso_with_checksum_md5_negative | `Error` | 66.67 | test_iso.py
test_03_create_iso_with_checksum_md5 | `Error` | 65.66 | test_iso.py
test_03_create_iso_with_checksum_md5 | `Error` | 66.79 | test_iso.py
test_04_create_iso_with_no_checksum | `Error` | 65.67 | test_iso.py
test_04_create_iso_with_no_checksum | `Error` | 66.76 | test_iso.py
test_01_create_iso | `Failure` | 1517.64 | test_iso.py
ContextSuite context=TestISO>:setup | `Error` | 3036.02 | test_iso.py
ContextSuite context=TestDeployVmWithUserData>:setup | `Error` | 0.00 | test_deploy_vm_with_userdata.py
ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py
ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py
ContextSuite context=TestDomainsServiceOfferings>:setup | `Error` | 2.91 | test_domain_service_offerings.py
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
test_list_vms_metrics | `Error` | 0.28 | test_metrics_api.py
test_nic_secondaryip_add_remove | `Error` | 0.05 | test_multipleips_per_nic.py
ContextSuite context=TestNestedVirtualization>:setup | `Error` | 0.00 | test_nested_virtualization.py
ContextSuite context=TestNetworkACL>:setup | `Error` | 0.00 | test_network_acl.py
test_delete_account | `Error` | 0.47 | test_network.py
test_delete_network_while_vm_on_it | `Error` | 0.09 | test_network.py
test_deploy_vm_l2network | `Error` | 0.10 | test_network.py
test_l2network_restart | `Error` | 0.15 | test_network.py
ContextSuite context=TestPortForwarding>:setup | `Error` | 1.54 | test_network.py
ContextSuite context=TestPublicIP>:setup | `Error` | 1.06 | test_network.py
test_reboot_router | `Error` | 0.06 | test_network.py
test_releaseIP | `Error` | 0.48 | test_network.py
ContextSuite context=TestRouterRules>:setup | `Error` | 0.58 | test_network.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestPortForwardingRules>:setup | `Error` | 0.00 | test_portforwardingrules.py
ContextSuite context=TestPrivateGwACL>:setup | `Error` | 0.00 | test_privategw_acl.py
test_09_project_suspend | `Error` | 0.10 | test_projects.py
test_10_project_activation | `Error` | 0.09 | test_projects.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 0.21 | test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 0.28 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.87 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 3.20 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 340.68 | test_vpc_redundant.py
test_hostha_kvm_host_fencing | `Error` | 177.66 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-690884775
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-692586363
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4316: Handle listProjects API to list projects with user as Project Admin when listAll=true
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-690063521
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-690873863
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4316: Handle listProjects API to list projects with user as Project Admin when listAll=true
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#discussion_r486122077
##########
File path: server/src/main/java/com/cloud/acl/DomainChecker.java
##########
@@ -199,6 +200,9 @@ public boolean checkAccess(Account caller, ControlledEntity entity, AccessType a
private boolean checkOperationPermitted(Account caller, ControlledEntity entity) {
User user = CallContext.current().getCallingUser();
Project project = projectDao.findByProjectAccountId(entity.getAccountId());
+ if (project == null) {
Review comment:
this method is called only if the entity is owned by a project - which would mean that ideally project should be present if the entity's account is of Project type
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-691657252
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1985
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4316: Handle listProjects API to list projects with user as Project Admin when listAll=true
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-690059012
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1950
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-690857260
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-690857260
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-693233589
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-690857260
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-692587389
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-691655481
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4316: Handle listProjects API to list projects with user as Project Admin when listAll=true
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#discussion_r486119214
##########
File path: server/src/main/java/com/cloud/acl/DomainChecker.java
##########
@@ -199,6 +200,9 @@ public boolean checkAccess(Account caller, ControlledEntity entity, AccessType a
private boolean checkOperationPermitted(Account caller, ControlledEntity entity) {
User user = CallContext.current().getCallingUser();
Project project = projectDao.findByProjectAccountId(entity.getAccountId());
+ if (project == null) {
Review comment:
Are there usage of this method where throwing an exception would break flow? (or, are we expecting all usages of this method to be project related?)
##########
File path: server/src/main/java/com/cloud/network/NetworkModelImpl.java
##########
@@ -1658,6 +1658,9 @@ public void checkNetworkPermissions(Account owner, Network network) {
if (owner.getType() != Account.ACCOUNT_TYPE_PROJECT && networkOwner.getType() == Account.ACCOUNT_TYPE_PROJECT) {
User user = CallContext.current().getCallingUser();
Project project = projectDao.findByProjectAccountId(network.getAccountId());
+ if (project == null) {
Review comment:
Same as previous comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-693697191
<b>Trillian test result (tid-2754)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50934 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4316-t2754-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 82 look OK, 3 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_deploy_kubernetes_cluster | `Error` | 0.08 | test_kubernetes_clusters.py
test_02_deploy_kubernetes_ha_cluster | `Error` | 0.04 | test_kubernetes_clusters.py
test_04_deploy_and_upgrade_kubernetes_cluster | `Error` | 0.04 | test_kubernetes_clusters.py
test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Error` | 0.03 | test_kubernetes_clusters.py
test_06_deploy_and_invalid_upgrade_kubernetes_cluster | `Error` | 0.03 | test_kubernetes_clusters.py
test_07_deploy_and_scale_kubernetes_cluster | `Error` | 0.04 | test_kubernetes_clusters.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 433.15 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | `Failure` | 436.55 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 432.88 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Error` | 3856.49 | test_vpc_redundant.py
test_hostha_kvm_host_fencing | `Error` | 98.32 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-690857576
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-690873278
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1954
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4316: Handle listProjects API to list projects with user as Project Admin when listAll=true
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#discussion_r486122353
##########
File path: server/src/main/java/com/cloud/network/NetworkModelImpl.java
##########
@@ -1658,6 +1658,9 @@ public void checkNetworkPermissions(Account owner, Network network) {
if (owner.getType() != Account.ACCOUNT_TYPE_PROJECT && networkOwner.getType() == Account.ACCOUNT_TYPE_PROJECT) {
User user = CallContext.current().getCallingUser();
Project project = projectDao.findByProjectAccountId(network.getAccountId());
+ if (project == null) {
Review comment:
here too, the check is explicitly for networks owned by a project
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-692611564
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2013
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-692537047
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316#issuecomment-691655399
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4316: Handle listProjects API to list projects with user as members when listAll=true
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4316:
URL: https://github.com/apache/cloudstack/pull/4316
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org