[GitHub] [incubator-pekko] mdedetrich commented on issue #339: source release: include a version.sbt

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on issue #339:
URL: https://github.com/apache/incubator-pekko/issues/339#issuecomment-1561704175

   A lot of the points we already discussed in https://github.com/apache/incubator-pekko/issues/130 but unless there is a formal ASF requirement I wouldn't put that much effort/energy into putting `build.sbt` into the source package and using it as a source of truth for the version.
   
   As stated elsewhere, aside from verification purposes there is going to be close to no one actually downloading the source package, everyone will download the binary jars from maven via their JVM based build tool as a dependency. Also as discussed in https://github.com/apache/incubator-pekko/issues/130#issuecomment-1410210094, the reason why we wanted to use git tags is that it works completely seamlessly with sbt-dyn-ver and because of that the entire release process is very simple.
   
   In short, if we start hardcoding the `version` in `build.sbt` at best its largely going to be ceremonial and at worst it can cause problems/conflicts. In fact [sbt-dynver](https://github.com/sbt/sbt-dynver) already states to **NOT** use a static version in build.sbt, directly quoting their README
   
   > Then make sure to NOT set the version setting, otherwise you will override sbt-dynver.
   
   > Note that Apache releases are done manually by Release Managers (humans) and that the release won't be based on an automated job that starts when a git tag is added. The git tag is still useful but it doesn't drive the build.
   
   This was already discussed and its quite easy to handle this problem. Release managers are responsible for creating a git tag when a release is being announced and other committers can either refer to that tag to build the software or just download the source (which will point to the git tag).
   
   > If we include this file in the source release (generated by the sbt-source-dist plugin), then that affects the jar names that will be created and I think it makes sense that our '1.0.0' source release builds jars with '1.0.0' version on them.
   
   It will also completely break sbt-dynver which all of our snapshots rely on to work correctly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org