You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/12/04 20:38:23 UTC
[kudu-CR] char util-test: disable TSAN instrumentation in stress tests
Adar Dembo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14835
Change subject: char_util-test: disable TSAN instrumentation in stress tests
......................................................................
char_util-test: disable TSAN instrumentation in stress tests
The UTF8 stress test was sometimes timing out in TSAN precommit.
Change-Id: Ibaafba2e73cdfeec3ca3f7091cedc316238600b2
---
M src/kudu/util/char_util-test.cc
M src/kudu/util/char_util.cc
2 files changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/14835/1
--
To view, visit http://gerrit.cloudera.org:8080/14835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibaafba2e73cdfeec3ca3f7091cedc316238600b2
Gerrit-Change-Number: 14835
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
[kudu-CR] char util-test: disable TSAN instrumentation in stress tests
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14835 )
Change subject: char_util-test: disable TSAN instrumentation in stress tests
......................................................................
char_util-test: disable TSAN instrumentation in stress tests
The UTF8 stress test was sometimes timing out in TSAN precommit.
Change-Id: Ibaafba2e73cdfeec3ca3f7091cedc316238600b2
Reviewed-on: http://gerrit.cloudera.org:8080/14835
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/util/char_util-test.cc
M src/kudu/util/char_util.cc
2 files changed, 8 insertions(+), 2 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Adar Dembo: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibaafba2e73cdfeec3ca3f7091cedc316238600b2
Gerrit-Change-Number: 14835
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] char util-test: disable TSAN instrumentation in stress tests
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14835 )
Change subject: char_util-test: disable TSAN instrumentation in stress tests
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaafba2e73cdfeec3ca3f7091cedc316238600b2
Gerrit-Change-Number: 14835
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 04 Dec 2019 21:26:21 +0000
Gerrit-HasComments: No
[kudu-CR] char util-test: disable TSAN instrumentation in stress tests
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14835 )
Change subject: char_util-test: disable TSAN instrumentation in stress tests
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaafba2e73cdfeec3ca3f7091cedc316238600b2
Gerrit-Change-Number: 14835
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 04 Dec 2019 23:38:38 +0000
Gerrit-HasComments: No
[kudu-CR] char util-test: disable TSAN instrumentation in stress tests
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14835 )
Change subject: char_util-test: disable TSAN instrumentation in stress tests
......................................................................
Patch Set 3: Verified+1
Overriding Jenkins, ITClientStress timed out in TSAN mode, and I've published a separate patch for that.
--
To view, visit http://gerrit.cloudera.org:8080/14835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaafba2e73cdfeec3ca3f7091cedc316238600b2
Gerrit-Change-Number: 14835
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 05 Dec 2019 00:14:00 +0000
Gerrit-HasComments: No
[kudu-CR] char util-test: disable TSAN instrumentation in stress tests
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/14835 )
Change subject: char_util-test: disable TSAN instrumentation in stress tests
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ibaafba2e73cdfeec3ca3f7091cedc316238600b2
Gerrit-Change-Number: 14835
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>