[GitHub] [beam] je-ik commented on a diff in pull request #25554: Backlog metrics do not showing up in FlinkRunner

["je-ik (via GitHub)" <gi...@apache.org>]

je-ik commented on code in PR #25554:
URL: https://github.com/apache/beam/pull/25554#discussion_r1118751090


##########
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/io/UnboundedSourceWrapper.java:
##########
@@ -391,6 +391,9 @@ public void snapshotState(FunctionSnapshotContext functionSnapshotContext) throw
         return;
       }
 
+      ReaderInvocationUtil<OutputT, UnboundedSource.UnboundedReader<OutputT>> readerInvoker =
+          new ReaderInvocationUtil<>(stepName, serializedOptions.get(), metricContainer);

Review Comment:
   This can be moved to a field and reused between calls to `run` and `snapshotState`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org