You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/01/05 03:10:25 UTC
[GitHub] [hive] nareshpr opened a new pull request #1825: HIVE-24523: Vectorized read path for LazySimpleSerde does not honor the SERDEPROPERTIES for timestamp
nareshpr opened a new pull request #1825:
URL: https://github.com/apache/hive/pull/1825
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] nareshpr commented on pull request #1825: HIVE-24523: Vectorized read path for LazySimpleSerde does not honor the SERDEPROPERTIES for timestamp
Posted by GitBox <gi...@apache.org>.
nareshpr commented on pull request #1825:
URL: https://github.com/apache/hive/pull/1825#issuecomment-759080321
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] nareshpr commented on a change in pull request #1825: HIVE-24523: Vectorized read path for LazySimpleSerde does not honor the SERDEPROPERTIES for timestamp
Posted by GitBox <gi...@apache.org>.
nareshpr commented on a change in pull request #1825:
URL: https://github.com/apache/hive/pull/1825#discussion_r555979539
##########
File path: serde/src/java/org/apache/hadoop/hive/serde2/lazy/fast/LazySimpleDeserializeRead.java
##########
@@ -350,7 +350,12 @@ public LazySimpleDeserializeRead(TypeInfo[] typeInfos,
throw new RuntimeException("serialization.last.column.takes.rest not supported");
}
- timestampParser = new TimestampParser();
+ List<String> timestampFormats = lazyParams.getTimestampFormats();
+ if (timestampFormats != null) {
Review comment:
Thanks for the review @deniskuzZ.
I updated the code with ternary operator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a change in pull request #1825: HIVE-24523: Vectorized read path for LazySimpleSerde does not honor the SERDEPROPERTIES for timestamp
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on a change in pull request #1825:
URL: https://github.com/apache/hive/pull/1825#discussion_r554879974
##########
File path: serde/src/java/org/apache/hadoop/hive/serde2/lazy/fast/LazySimpleDeserializeRead.java
##########
@@ -350,7 +350,12 @@ public LazySimpleDeserializeRead(TypeInfo[] typeInfos,
throw new RuntimeException("serialization.last.column.takes.rest not supported");
}
- timestampParser = new TimestampParser();
+ List<String> timestampFormats = lazyParams.getTimestampFormats();
+ if (timestampFormats != null) {
Review comment:
minor: i would use ternary operator here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ merged pull request #1825: HIVE-24523: Vectorized read path for LazySimpleSerde does not honor the SERDEPROPERTIES for timestamp
Posted by GitBox <gi...@apache.org>.
deniskuzZ merged pull request #1825:
URL: https://github.com/apache/hive/pull/1825
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on pull request #1825: HIVE-24523: Vectorized read path for LazySimpleSerde does not honor the SERDEPROPERTIES for timestamp
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on pull request #1825:
URL: https://github.com/apache/hive/pull/1825#issuecomment-758892115
hi @nareshpr, could you please fill in description in the pull request, so I could merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org