[GitHub] clebertsuconic commented on a change in pull request #2479: ARTEMIS-2211 Avoid duplicate code for ByteBuffer pooling and alignment

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #2479: ARTEMIS-2211 Avoid duplicate code for ByteBuffer pooling and alignment
URL: https://github.com/apache/activemq-artemis/pull/2479#discussion_r248716417
 
 

 ##########
 File path: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/BitUtil.java
 ##########
 @@ -14,19 +14,23 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.apache.activemq.artemis.core.io.mapped;
+package org.apache.activemq.artemis.utils;
 
-import java.nio.ByteBuffer;
-
-import io.netty.util.internal.PlatformDependent;
-
-final class BytesUtils {
+/**
+ * Collection of bit-tricks
+ */
+public final class BitUtil {
 
 Review comment:
   We already have another class ByteUtil on the same package.
   
   it will be confusing to have on ByteUtil and another BitsUtil.
   
   
   Can you just move the methods to the same class with some documentation on these methods?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services