[jira] [Commented] (ARTEMIS-4962) possible NPE in FilterImpl

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-4962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878980#comment-17878980 ] 

ASF subversion and git services commented on ARTEMIS-4962:
----------------------------------------------------------

Commit d929c5dd6636cd5975ab35800202d059796d3cc6 in activemq-artemis's branch refs/heads/main from Justin Bertram
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=d929c5dd66 ]

ARTEMIS-4962 mitigate NPE in FilterImpl


> possible NPE in FilterImpl
> --------------------------
>
>                 Key: ARTEMIS-4962
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4962
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Ekaterina Zilotina
>            Assignee: Justin Bertram
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> In {{FilterImpl}} there is potential {{NullPointerException}} in the private method {{GetHeaderFieldValue()}} ([line 169|https://github.com/apache/activemq-artemis/blob/75f17ba64df10663a14fcc85bcb5398d23941b6d/artemis-server/src/main/java/org/apache/activemq/artemis/core/filter/impl/FilterImpl.java#L169]).
> When condition in line 161 is {{true}} and condition in line 164 is {{false}} then {{null}} return value of {{msg.getUserID()}} (cause in line 161 was true condition) derefers in 169. Is it absolutely true that in complex these conditions must only works as "true+true" or be skipped by first "false"? Does this part of code need another check before 169 line?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@activemq.apache.org
For additional commands, e-mail: issues-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact