You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "github-actions[bot] (via GitHub)" <gi...@apache.org> on 2023/04/03 08:00:16 UTC

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18340: [fix](file_cache) turn on file cache by FE session variable

github-actions[bot] commented on code in PR #18340:
URL: https://github.com/apache/doris/pull/18340#discussion_r1155610410


##########
be/src/vec/exec/format/parquet/parquet_thrift_util.h:
##########
@@ -35,12 +35,13 @@ namespace doris::vectorized {
 constexpr uint8_t PARQUET_VERSION_NUMBER[4] = {'P', 'A', 'R', '1'};
 constexpr uint32_t PARQUET_FOOTER_SIZE = 8;
 
-static Status parse_thrift_footer(io::FileReaderSPtr file, FileMetaData** file_metadata) {
+static Status parse_thrift_footer(io::FileReaderSPtr file, FileMetaData** file_metadata,

Review Comment:
   warning: unused function 'parse_thrift_footer' [clang-diagnostic-unused-function]
   ```cpp
   static Status parse_thrift_footer(io::FileReaderSPtr file, FileMetaData** file_metadata,
                 ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org