[druid] branch master updated: Fix the Injector creation in HadoopTask (#13138)

[ab...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

abhishek pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git


The following commit(s) were added to refs/heads/master by this push:
     new 0bfa81b7df Fix the Injector creation in HadoopTask (#13138)
0bfa81b7df is described below

commit 0bfa81b7df4b0ae76ac45497b007b6857acb419f
Author: Laksh Singla <la...@gmail.com>
AuthorDate: Sat Sep 24 10:38:25 2022 +0530

    Fix the Injector creation in HadoopTask (#13138)
    
    * Injector fix in HadoopTask
    
    * Log the ExtensionsConfig while instantiating the HadoopTask
    
    * Log the config in the run() method instead of the ctor
---
 .../apache/druid/indexing/common/task/HadoopIndexTask.java    |  1 +
 .../org/apache/druid/indexing/common/task/HadoopTask.java     | 11 ++++++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/indexing-service/src/main/java/org/apache/druid/indexing/common/task/HadoopIndexTask.java b/indexing-service/src/main/java/org/apache/druid/indexing/common/task/HadoopIndexTask.java
index 04e4f03ebe..bd2befef8b 100644
--- a/indexing-service/src/main/java/org/apache/druid/indexing/common/task/HadoopIndexTask.java
+++ b/indexing-service/src/main/java/org/apache/druid/indexing/common/task/HadoopIndexTask.java
@@ -330,6 +330,7 @@ public class HadoopIndexTask extends HadoopTask implements ChatHandler
     try {
       registerResourceCloserOnAbnormalExit(config -> killHadoopJob());
       String hadoopJobIdFile = getHadoopJobIdFileName();
+      logExtensionsConfig();
       final ClassLoader loader = buildClassLoader(toolbox);
       boolean determineIntervals = spec.getDataSchema().getGranularitySpec().inputIntervals().isEmpty();
 
diff --git a/indexing-service/src/main/java/org/apache/druid/indexing/common/task/HadoopTask.java b/indexing-service/src/main/java/org/apache/druid/indexing/common/task/HadoopTask.java
index d07627e102..300ec5bac2 100644
--- a/indexing-service/src/main/java/org/apache/druid/indexing/common/task/HadoopTask.java
+++ b/indexing-service/src/main/java/org/apache/druid/indexing/common/task/HadoopTask.java
@@ -50,7 +50,7 @@ public abstract class HadoopTask extends AbstractBatchIndexTask
 {
   private static final Logger log = new Logger(HadoopTask.class);
 
-  static final Injector INJECTOR = new StartupInjectorBuilder().withExtensions().build();
+  static final Injector INJECTOR = new StartupInjectorBuilder().forServer().build();
   private static final ExtensionsLoader EXTENSIONS_LOADER = ExtensionsLoader.instance(INJECTOR);
 
   private final List<String> hadoopDependencyCoordinates;
@@ -207,6 +207,15 @@ public abstract class HadoopTask extends AbstractBatchIndexTask
     return classLoader;
   }
 
+  /**
+   * This method logs the {@link ExtensionsConfig} that was used to fetch the hadoop dependencies and build the classpath
+   * for the jobs
+   */
+  protected static void logExtensionsConfig()
+  {
+    log.info("HadoopTask started with the following config:\n%s", EXTENSIONS_LOADER.config().toString());
+  }
+
   /**
    * This method tries to isolate class loading during a Function call
    *


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org