You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "spmallette (via GitHub)" <gi...@apache.org> on 2026/06/15 21:41:24 UTC
[PR] TINKERPOP-3238 Throw FailResponseException for fail() step over remote [tinkerpop]
spmallette opened a new pull request, #3460:
URL: https://github.com/apache/tinkerpop/pull/3460
The Java driver now throws a FailResponseException, a subclass of ResponseException that implements Failure, when the server returns a SERVER_ERROR_FAIL_STEP (595) status code. This makes remote handling of the fail() step more consistent with embedded behavior.
Failure.format() is guarded against null traversal/traverser context since that data is not transmitted from the server, preventing a NullPointerException when formatting a remotely-reconstructed Failure.
Adds unit tests for both the defensive format() logic and the new exception, plus documentation in the reference and upgrade guides.
@kenhuuu could you say what this change means in 4.0? I don't know that we have the same kind of Exception hierarchy there anymore iirc
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TINKERPOP-3238 Throw FailResponseException for fail() step over remote [tinkerpop]
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #3460:
URL: https://github.com/apache/tinkerpop/pull/3460#issuecomment-4725505103
> could you say what this change means in 4.0? I don't know that we have the same kind of Exception hierarchy there anymore iirc
we still use ResponseException and could probably do something very similar to what is done here. We don't have that same error code anymore but we do get a "ServerFailStepException" as the exception type in the response so we'd use that as the conditional instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TINKERPOP-3238 Throw FailResponseException for fail() step over remote [tinkerpop]
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #3460:
URL: https://github.com/apache/tinkerpop/pull/3460#issuecomment-4782770127
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TINKERPOP-3238 Throw FailResponseException for fail() step over remote [tinkerpop]
Posted by "spmallette (via GitHub)" <gi...@apache.org>.
spmallette merged PR #3460:
URL: https://github.com/apache/tinkerpop/pull/3460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TINKERPOP-3238 Throw FailResponseException for fail() step over remote [tinkerpop]
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #3460:
URL: https://github.com/apache/tinkerpop/pull/3460#issuecomment-4735515076
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org