[jira] [Commented] (HDFS-12309) Incorrect null check in the AdminHelper.java

["Elek, Marton (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-12309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686348#comment-16686348 ] 

Elek, Marton commented on HDFS-12309:
-------------------------------------

Thank you [~olegd] to post this patch. Unfortunately I found it just now and in the meantime it's fixed in HDFS-13261.

Will close this issue as of now. 

> Incorrect null check in the AdminHelper.java
> --------------------------------------------
>
>                 Key: HDFS-12309
>                 URL: https://issues.apache.org/jira/browse/HDFS-12309
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Oleg Danilov
>            Priority: Trivial
>         Attachments: HDFS-12309.patch
>
>
> '!= null' is not required there:
> line 147-150:
> {code:java}
>     public HelpCommand(Command[] commands) {
>       Preconditions.checkNotNull(commands != null);
>       this.commands = commands;
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org