You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2020/07/04 13:49:47 UTC
[GitHub] [httpcomponents-client] nielsbasjes opened a new pull request #234: Add Automatic-Module-Name in manifest so Java9 modular applications c…
nielsbasjes opened a new pull request #234:
URL: https://github.com/apache/httpcomponents-client/pull/234
…an depend on this library.
This is essentially a duplication of https://github.com/apache/httpcomponents-client/pull/104 but now for the 5.x versions.
As indicated here https://github.com/apache/httpcomponents-client/pull/104#issuecomment-403436258 I have made sure the module names to not contain a hyphen ('-').
Looking at what was done for the 4.x version I have chosen to stick as close as possible to essentially `groupdId.artifactId` as possible.
Please indicate if this is the right choice or if you want something different.
I see this as a very important choice to get right at this point as it is something I expect will be hard to change in the future.
I added this to ALL maven artifacts (also the -testing), please asses if this is correct.
Please commit this into both master and the 5.1.x branch if you agree with these changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c merged pull request #234: Add Automatic-Module-Name in manifest so Java9 modular applications c…
Posted by GitBox <gi...@apache.org>.
ok2c merged pull request #234:
URL: https://github.com/apache/httpcomponents-client/pull/234
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] nielsbasjes commented on pull request #234: Add Automatic-Module-Name in manifest so Java9 modular applications c…
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on pull request #234:
URL: https://github.com/apache/httpcomponents-client/pull/234#issuecomment-653769041
Note that I have created the same change for both [httpcomponents-core](https://github.com/apache/httpcomponents-core/pull/200) and [httpcomponents-client](https://github.com/apache/httpcomponents-client/pull/234).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] nielsbasjes commented on pull request #234: Add Automatic-Module-Name in manifest so Java9 modular applications c…
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on pull request #234:
URL: https://github.com/apache/httpcomponents-client/pull/234#issuecomment-653782642
I do not understand how my change could have caused this test to fail (only on jdk 7).
Please assist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] michael-o commented on pull request #234: Add Automatic-Module-Name in manifest so Java9 modular applications c…
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #234:
URL: https://github.com/apache/httpcomponents-client/pull/234#issuecomment-653910436
That's OK for me although the module names see quite long almost like OSGi symbolic names. Maybe, `apache-httpclient5-x` `httpclient5-x` would be easier to memorize?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #234: Add Automatic-Module-Name in manifest so Java9 modular applications c…
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #234:
URL: https://github.com/apache/httpcomponents-client/pull/234#issuecomment-654350968
@michael-o @garydgregory If I hear no objections I will merge this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c edited a comment on pull request #234: Add Automatic-Module-Name in manifest so Java9 modular applications c…
Posted by GitBox <gi...@apache.org>.
ok2c edited a comment on pull request #234:
URL: https://github.com/apache/httpcomponents-client/pull/234#issuecomment-653903366
@nielsbasjes This failure has nothing to do with your changes. Apparently there is a very nasty and rare race condition in our reactive bindings that triggers on Travis CI hosts only. I was not able to reproduce the issue neither locally nor with ASF Jenkins CI intrastructure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] michael-o commented on pull request #234: Add Automatic-Module-Name in manifest so Java9 modular applications c…
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #234:
URL: https://github.com/apache/httpcomponents-client/pull/234#issuecomment-654114441
@nielsbasjes Great explanation. Will happily accept it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #234: Add Automatic-Module-Name in manifest so Java9 modular applications c…
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #234:
URL: https://github.com/apache/httpcomponents-client/pull/234#issuecomment-653903366
@nielsbasjes This failure has nothing to do with your changes. Apparently there is a very nasty and rare race condition in our reactive bindings that occurs on Travis CI hosts only. I was not able to reproduce the issue neither locally nor with ASF Jenkins CI intrastructure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] nielsbasjes commented on pull request #234: Add Automatic-Module-Name in manifest so Java9 modular applications c…
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on pull request #234:
URL: https://github.com/apache/httpcomponents-client/pull/234#issuecomment-654215957
Note that I do see room for simplifying the used module names.
I simply chose to stick to the 'exact' `groupId.artifactId` for clarity and less confusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #234: Add Automatic-Module-Name in manifest so Java9 modular applications c…
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #234:
URL: https://github.com/apache/httpcomponents-client/pull/234#issuecomment-653903607
Folks, any objection to the proposed changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] nielsbasjes commented on pull request #234: Add Automatic-Module-Name in manifest so Java9 modular applications c…
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on pull request #234:
URL: https://github.com/apache/httpcomponents-client/pull/234#issuecomment-654048215
@michael-o
At this moment I have limited experience in using modules. So for making this patch I did some digging and what I found is that these module names must be just as unique as the name of packages and artifacts.
Quote from: https://openjdk.java.net/projects/jigsaw/spec/sotms/#module-declarations
> Module names, like package names, must not conflict. The recommended way to name a module is to use the reverse-domain-name pattern that has long been recommended for naming packages. The name of a module will, therefore, often be a prefix of the names of its exported packages, but this relationship is not mandatory.
So that is why in my pull requests I used exactly that: ```groupId.artifactId``` which is essentially the same as what was done for the 4.x versions.
See also https://stackoverflow.com/questions/43192741/how-should-i-name-my-java-9-module
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org