[jira] [Commented] (OFBIZ-7828) Entity and Service definition

["Rishi Solanki (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-7828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079530#comment-16079530 ] 

Rishi Solanki commented on OFBIZ-7828:
--------------------------------------

ShipmentItemBilling, Lot and CommEventContentAssoc entities work still remains. Also not able to find more entities/services which fall under this category except OrderHeader. So This ticket is towards completion.

The above entities have many occurrence of delegator used inline in the code. And bit complex to replace by services, will do some sanity and upload the patches soon. After that this we can say this ticket is complete. 

> Entity and Service definition
> -----------------------------
>
>                 Key: OFBIZ-7828
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7828
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Rishi Solanki
>            Assignee: Arun Patidar
>
> As per discussion on dev list on email thread-: "Entity and Service definition" Here is the parent task for the same.
> TODO's from same thread, review entities/services on following parameters;
> 1) Many entity definitions having relationships with view-entities, like OrderHeader entity maintain relationship with OrderHeaderNoteView and OrderItemAndShipGroupAssoc. We should remove it, maintain the relationship at view-entities level if required. Also change the code where this relation is in use.
> 2) Many entities having service implementation exists but they can be simply convert into entity-auto, that means can use the power OFBiz provides.
> 3) As mentioned initially many entities do not have CRUD services exists, we should implement or use entity-auto for them wherever applicable. Also remove direct use of delegator for them.
> 4) Many entities having from date and thru date, Or status Or Enumeration to manage the historical data, but services actually remove those entity data. We should change the service implementation to maintain the historical data.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)