[Impala-CR](cdh5-trunk) Specify whether to clone IR function in GetFunction() instead of ReplaceCallSites()

["Dan Hecht (Code Review)" <ge...@cloudera.org>]

Dan Hecht has posted comments on this change.

Change subject: Specify whether to clone IR function in GetFunction() instead of ReplaceCallSites()
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

Nice cleanup.

http://gerrit.cloudera.org:8080/#/c/2112/2/be/src/codegen/llvm-codegen.h
File be/src/codegen/llvm-codegen.h:

Line 532:   /// bool is unused.
if bool is unused, why do we have it?


-- 
To view, visit http://gerrit.cloudera.org:8080/2112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8eabb5c062ee223c5de9df40aacfdc9dcda5ba63
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Skye Wanderman-Milne <sk...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <sk...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes