You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Mark Chu-Carroll <mc...@twopensource.com> on 2014/05/07 20:48:32 UTC
Review Request 21170: Make the "task run" command accept an instances spec.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21170/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin and Suman Karumuri.
Bugs: aurora-198
https://issues.apache.org/jira/browse/aurora-198
Repository: aurora
Description
-------
Make the "task run" command accept an instances spec.
Also, add a subclass of DistributedCommandRunner that takes an instance list, and runs a command
only on the specific task instances in that list.
Diffs
-----
src/main/python/apache/aurora/client/api/command_runner.py 1af6a782d6c0c419702ebfe0935eebbba0ea888a
src/main/python/apache/aurora/client/cli/options.py 040c5c213798e644ba59c4ce3f9c4fe8868af2d5
src/main/python/apache/aurora/client/cli/task.py a162b86e465991f14160ceff465ddd7d110b57a3
src/test/python/apache/aurora/client/cli/test_task_run.py fba812efc2292be3d66cb821f0877b60afa28072
Diff: https://reviews.apache.org/r/21170/diff/
Testing
-------
[sun-wukong incubator-aurora (run_with_instances)]$ ./pants src/test/python/apache/aurora/client/cli:task
Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/cli/BUILD:task)])
============================== test session starts ===============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 3 items
src/test/python/apache/aurora/client/cli/test_task_run.py ...
============================ 3 passed in 0.64 seconds ============================
src.test.python.apache.aurora.client.cli.task ..... SUCCESS
[sun-wukong incubator-aurora (run_with_instances)]$
Thanks,
Mark Chu-Carroll
Re: Review Request 21170: Make the "task run" command accept an instances
spec.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21170/#review42586
-----------------------------------------------------------
src/main/python/apache/aurora/client/api/command_runner.py
<https://reviews.apache.org/r/21170/#comment76400>
Should add the response code to this log message.
- David McLaughlin
On May 7, 2014, 6:48 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21170/
> -----------------------------------------------------------
>
> (Updated May 7, 2014, 6:48 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Suman Karumuri.
>
>
> Bugs: aurora-198
> https://issues.apache.org/jira/browse/aurora-198
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Make the "task run" command accept an instances spec.
>
> Also, add a subclass of DistributedCommandRunner that takes an instance list, and runs a command
> only on the specific task instances in that list.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/command_runner.py 1af6a782d6c0c419702ebfe0935eebbba0ea888a
> src/main/python/apache/aurora/client/cli/options.py 040c5c213798e644ba59c4ce3f9c4fe8868af2d5
> src/main/python/apache/aurora/client/cli/task.py a162b86e465991f14160ceff465ddd7d110b57a3
> src/test/python/apache/aurora/client/cli/test_task_run.py fba812efc2292be3d66cb821f0877b60afa28072
>
> Diff: https://reviews.apache.org/r/21170/diff/
>
>
> Testing
> -------
>
> [sun-wukong incubator-aurora (run_with_instances)]$ ./pants src/test/python/apache/aurora/client/cli:task
> Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/cli/BUILD:task)])
> ============================== test session starts ===============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 3 items
>
> src/test/python/apache/aurora/client/cli/test_task_run.py ...
>
> ============================ 3 passed in 0.64 seconds ============================
> src.test.python.apache.aurora.client.cli.task ..... SUCCESS
> [sun-wukong incubator-aurora (run_with_instances)]$
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 21170: Make the "task run" command accept an instances
spec.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21170/#review42587
-----------------------------------------------------------
Ship it!
- David McLaughlin
On May 7, 2014, 6:48 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21170/
> -----------------------------------------------------------
>
> (Updated May 7, 2014, 6:48 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Suman Karumuri.
>
>
> Bugs: aurora-198
> https://issues.apache.org/jira/browse/aurora-198
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Make the "task run" command accept an instances spec.
>
> Also, add a subclass of DistributedCommandRunner that takes an instance list, and runs a command
> only on the specific task instances in that list.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/command_runner.py 1af6a782d6c0c419702ebfe0935eebbba0ea888a
> src/main/python/apache/aurora/client/cli/options.py 040c5c213798e644ba59c4ce3f9c4fe8868af2d5
> src/main/python/apache/aurora/client/cli/task.py a162b86e465991f14160ceff465ddd7d110b57a3
> src/test/python/apache/aurora/client/cli/test_task_run.py fba812efc2292be3d66cb821f0877b60afa28072
>
> Diff: https://reviews.apache.org/r/21170/diff/
>
>
> Testing
> -------
>
> [sun-wukong incubator-aurora (run_with_instances)]$ ./pants src/test/python/apache/aurora/client/cli:task
> Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/cli/BUILD:task)])
> ============================== test session starts ===============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 3 items
>
> src/test/python/apache/aurora/client/cli/test_task_run.py ...
>
> ============================ 3 passed in 0.64 seconds ============================
> src.test.python.apache.aurora.client.cli.task ..... SUCCESS
> [sun-wukong incubator-aurora (run_with_instances)]$
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 21170: Make the "task run" command accept an instances
spec.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21170/
-----------------------------------------------------------
(Updated May 13, 2014, 3:33 p.m.)
Review request for Aurora, David McLaughlin and Suman Karumuri.
Changes
-------
Rebase to master.
Bugs: aurora-198
https://issues.apache.org/jira/browse/aurora-198
Repository: aurora
Description
-------
Make the "task run" command accept an instances spec.
Also, add a subclass of DistributedCommandRunner that takes an instance list, and runs a command
only on the specific task instances in that list.
Diffs (updated)
-----
src/main/python/apache/aurora/client/api/command_runner.py 14f8e454ac6b8fe2c2925f834d0761c053eea337
src/main/python/apache/aurora/client/cli/options.py bf86c3abe218d28b13a6d1bc25abe4f48e999b92
src/main/python/apache/aurora/client/cli/task.py 1253ece196413075c86840b633c61ebd2188a2fc
src/test/python/apache/aurora/client/cli/test_task_run.py c60189ca74bcd7152209430537ea2790e6db8457
Diff: https://reviews.apache.org/r/21170/diff/
Testing
-------
[sun-wukong incubator-aurora (run_with_instances)]$ ./pants src/test/python/apache/aurora/client/cli:task
Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/cli/BUILD:task)])
============================== test session starts ===============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 3 items
src/test/python/apache/aurora/client/cli/test_task_run.py ...
============================ 3 passed in 0.64 seconds ============================
src.test.python.apache.aurora.client.cli.task ..... SUCCESS
[sun-wukong incubator-aurora (run_with_instances)]$
Thanks,
Mark Chu-Carroll
Re: Review Request 21170: Make the "task run" command accept an instances
spec.
Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21170/#review42840
-----------------------------------------------------------
Ship it!
Ship It!
- Suman Karumuri
On May 7, 2014, 6:48 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21170/
> -----------------------------------------------------------
>
> (Updated May 7, 2014, 6:48 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Suman Karumuri.
>
>
> Bugs: aurora-198
> https://issues.apache.org/jira/browse/aurora-198
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Make the "task run" command accept an instances spec.
>
> Also, add a subclass of DistributedCommandRunner that takes an instance list, and runs a command
> only on the specific task instances in that list.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/command_runner.py 1af6a782d6c0c419702ebfe0935eebbba0ea888a
> src/main/python/apache/aurora/client/cli/options.py 040c5c213798e644ba59c4ce3f9c4fe8868af2d5
> src/main/python/apache/aurora/client/cli/task.py a162b86e465991f14160ceff465ddd7d110b57a3
> src/test/python/apache/aurora/client/cli/test_task_run.py fba812efc2292be3d66cb821f0877b60afa28072
>
> Diff: https://reviews.apache.org/r/21170/diff/
>
>
> Testing
> -------
>
> [sun-wukong incubator-aurora (run_with_instances)]$ ./pants src/test/python/apache/aurora/client/cli:task
> Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/cli/BUILD:task)])
> ============================== test session starts ===============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 3 items
>
> src/test/python/apache/aurora/client/cli/test_task_run.py ...
>
> ============================ 3 passed in 0.64 seconds ============================
> src.test.python.apache.aurora.client.cli.task ..... SUCCESS
> [sun-wukong incubator-aurora (run_with_instances)]$
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>