You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "xzyJavaX (via GitHub)" <gi...@apache.org> on 2023/07/18 01:45:44 UTC
[GitHub] [skywalking] xzyJavaX opened a new issue, #11106: [Bug] Repeated enhancement occurs in mysql-5.x-plugin.
xzyJavaX opened a new issue, #11106:
URL: https://github.com/apache/skywalking/issues/11106
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues.
### Apache SkyWalking Component
Java Agent (apache/skywalking-java)
### What happened
Both `org.apache.skywalking.apm.plugin.jdbc.mysql.v5.define.CacheIpsInstrumentation` and `org.apache.skywalking.apm.plugin.jdbc.mysql.v5.define.DriverInstrumentation` have enhanced the `connect` method of `com.mysql.jdbc.Driver` and `com.mysql.jdbc.NonRegisteringDriver`.
BTW, why do we need to enhance both `com.mysql.jdbc.Driver` and `com.mysql.jdbc.NonRegisteringDriver`? This sometimes leads to the method in interceptor being called twice.
### What you expected to happen
No response
### How to reproduce
No response
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #11106: [Bug] Repeated enhancement occurs in mysql-5.x-plugin.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng closed issue #11106: [Bug] Repeated enhancement occurs in mysql-5.x-plugin.
URL: https://github.com/apache/skywalking/issues/11106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #11106: [Bug] Repeated enhancement occurs in mysql-5.x-plugin.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #11106:
URL: https://github.com/apache/skywalking/issues/11106#issuecomment-1639269064
We are not sure about that, but be careful when you want to remove something, it could be a bug trigger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org