You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Lavkesh Lahngir <la...@gmail.com> on 2017/04/11 09:48:54 UTC
Review Request 58338: LENS-1410
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58338/
-----------------------------------------------------------
Review request for lens and Amareshwari Sriramadasu.
Bugs: LENS-1410
https://issues.apache.org/jira/browse/LENS-1410
Repository: lens
Description
-------
A string filer for getting for partition api must tbe provided
Diffs
-----
lens-api/src/main/resources/lens-errors.conf 29e24cf
lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 571b481
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 9d823da
Diff: https://reviews.apache.org/r/58338/diff/1/
Testing
-------
Thanks,
Lavkesh Lahngir
Re: Review Request 58338: LENS-1410
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On April 12, 2017, 5:35 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
> > Lines 1958 (patched)
> > <https://reviews.apache.org/r/58338/diff/2/?file=1687937#file1687937line1958>
> >
> > Can you update test for verfiying the error as well?
Reopening this. Can you update test verify error scenario as well?
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58338/#review171672
-----------------------------------------------------------
On April 12, 2017, 2:25 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58338/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 2:25 p.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-1410
> https://issues.apache.org/jira/browse/LENS-1410
>
>
> Repository: lens
>
>
> Description
> -------
>
> A string filer for getting for partition api must tbe provided
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf 29e24cf
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 9ea887a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java f176078
> lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 571b481
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 9d823da
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java f6f6e77
>
>
> Diff: https://reviews.apache.org/r/58338/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 58338: LENS-1410
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58338/#review171672
-----------------------------------------------------------
lens-api/src/main/resources/lens-errors.conf
Line 331 (original), 337 (patched)
<https://reviews.apache.org/r/58338/#comment244690>
New error should moved inside this.
lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java
Lines 65 (patched)
<https://reviews.apache.org/r/58338/#comment244689>
Can you change the number to 3105 ?
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
Lines 1958 (patched)
<https://reviews.apache.org/r/58338/#comment244688>
Can you update test for verfiying the error as well?
- Amareshwari Sriramadasu
On April 11, 2017, 11:58 a.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58338/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 11:58 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-1410
> https://issues.apache.org/jira/browse/LENS-1410
>
>
> Repository: lens
>
>
> Description
> -------
>
> A string filer for getting for partition api must tbe provided
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf 29e24cf
> lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 571b481
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 9d823da
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java f6f6e77
>
>
> Diff: https://reviews.apache.org/r/58338/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 58338: LENS-1410
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58338/#review172322
-----------------------------------------------------------
Ship it!
- Amareshwari Sriramadasu
On April 19, 2017, 6:57 a.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58338/
> -----------------------------------------------------------
>
> (Updated April 19, 2017, 6:57 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-1410
> https://issues.apache.org/jira/browse/LENS-1410
>
>
> Repository: lens
>
>
> Description
> -------
>
> A string filer for getting for partition api must tbe provided
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf 94505ef
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 9ea887a
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java befe4e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java f176078
> lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java d98c4c5
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 9ba1eb1
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java f6f6e77
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 064da01
>
>
> Diff: https://reviews.apache.org/r/58338/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 58338: LENS-1410
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58338/#review172323
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java
Lines 1004-1006 (patched)
<https://reviews.apache.org/r/58338/#comment245433>
we can move this check to service class, instead of resource class. All other validity checks are also done there.
- Rajat Khandelwal
On April 19, 2017, 12:27 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58338/
> -----------------------------------------------------------
>
> (Updated April 19, 2017, 12:27 p.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-1410
> https://issues.apache.org/jira/browse/LENS-1410
>
>
> Repository: lens
>
>
> Description
> -------
>
> A string filer for getting for partition api must tbe provided
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf 94505ef
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 9ea887a
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java befe4e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java f176078
> lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java d98c4c5
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 9ba1eb1
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java f6f6e77
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 064da01
>
>
> Diff: https://reviews.apache.org/r/58338/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 58338: LENS-1410
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58338/#review172321
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On April 19, 2017, 12:27 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58338/
> -----------------------------------------------------------
>
> (Updated April 19, 2017, 12:27 p.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-1410
> https://issues.apache.org/jira/browse/LENS-1410
>
>
> Repository: lens
>
>
> Description
> -------
>
> A string filer for getting for partition api must tbe provided
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf 94505ef
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 9ea887a
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java befe4e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java f176078
> lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java d98c4c5
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 9ba1eb1
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java f6f6e77
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 064da01
>
>
> Diff: https://reviews.apache.org/r/58338/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 58338: LENS-1410
Posted by Lavkesh Lahngir <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58338/
-----------------------------------------------------------
(Updated April 19, 2017, 6:57 a.m.)
Review request for lens and Amareshwari Sriramadasu.
Bugs: LENS-1410
https://issues.apache.org/jira/browse/LENS-1410
Repository: lens
Description
-------
A string filer for getting for partition api must tbe provided
Diffs (updated)
-----
lens-api/src/main/resources/lens-errors.conf 94505ef
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 9ea887a
lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java befe4e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java f176078
lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java d98c4c5
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 9ba1eb1
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java f6f6e77
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 064da01
Diff: https://reviews.apache.org/r/58338/diff/4/
Changes: https://reviews.apache.org/r/58338/diff/3-4/
Testing
-------
Thanks,
Lavkesh Lahngir
Re: Review Request 58338: LENS-1410
Posted by Lavkesh Lahngir <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58338/
-----------------------------------------------------------
(Updated April 12, 2017, 2:25 p.m.)
Review request for lens and Amareshwari Sriramadasu.
Bugs: LENS-1410
https://issues.apache.org/jira/browse/LENS-1410
Repository: lens
Description
-------
A string filer for getting for partition api must tbe provided
Diffs (updated)
-----
lens-api/src/main/resources/lens-errors.conf 29e24cf
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 9ea887a
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java f176078
lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 571b481
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 9d823da
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java f6f6e77
Diff: https://reviews.apache.org/r/58338/diff/3/
Changes: https://reviews.apache.org/r/58338/diff/2-3/
Testing
-------
Thanks,
Lavkesh Lahngir
Re: Review Request 58338: LENS-1410
Posted by Lavkesh Lahngir <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58338/
-----------------------------------------------------------
(Updated April 11, 2017, 11:58 a.m.)
Review request for lens and Amareshwari Sriramadasu.
Bugs: LENS-1410
https://issues.apache.org/jira/browse/LENS-1410
Repository: lens
Description
-------
A string filer for getting for partition api must tbe provided
Diffs (updated)
-----
lens-api/src/main/resources/lens-errors.conf 29e24cf
lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 571b481
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 9d823da
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java f6f6e77
Diff: https://reviews.apache.org/r/58338/diff/2/
Changes: https://reviews.apache.org/r/58338/diff/1-2/
Testing
-------
Thanks,
Lavkesh Lahngir