[GitHub] spark pull request #13152: [SPARK-15353] [CORE] Making peer selection for bl...

[ericl <gi...@git.apache.org>]

Github user ericl commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13152#discussion_r72685380
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ---
    @@ -159,8 +162,27 @@ private[spark] class BlockManager(
         blockTransferService.init(this)
         shuffleClient.init(appId)
     
    +    val topologyInfo = {
    +      val topologyStr = master.getTopologyInfo(blockTransferService.hostName)
    +      if (topologyStr == null || topologyStr.isEmpty) {
    +        None
    +      } else {
    +        Some(topologyStr)
    +      }
    +    }
    +
    +    blockReplicationPrioritizer = {
    +      val priorityClass = conf.get(
    +        "spark.replication.topologyawareness.prioritizer",
    +        "org.apache.spark.storage.DefaultBlockReplicationPrioritization")
    +      val clazz = Utils.classForName(priorityClass)
    +      val ret = clazz.newInstance.asInstanceOf[BlockReplicationPrioritization]
    +      logInfo(s"Using $priorityClass for prioritizing peers")
    +      ret
    +    }
    +
         blockManagerId = BlockManagerId(
    -      executorId, blockTransferService.hostName, blockTransferService.port)
    +      executorId, blockTransferService.hostName, blockTransferService.port, topologyInfo)
    --- End diff --
    
    Would it work if topologyInfo was sent back from the master when `registerBlockManager` is called? It doesn't seem that anything uses `blockManagerId` until registration finishes. That way we wouldn't need this weird two-step registration.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org