You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/17 16:15:41 UTC
[GitHub] [flink] rkhachatryan opened a new pull request #18382: [WIP][FLINK-25524][state/changelog] Fix checkpoint ID in completion notifications
rkhachatryan opened a new pull request #18382:
URL: https://github.com/apache/flink/pull/18382
TBD
cc: @curcur
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a change in pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #18382:
URL: https://github.com/apache/flink/pull/18382#discussion_r787871514
##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogStateBackend.java
##########
@@ -272,7 +273,16 @@ public StateBackend configure(ReadableConfig config, ClassLoader classLoader)
: new ChangelogStateBackendHandleImpl(
singletonList(keyedStateHandle),
emptyList(),
- keyedStateHandle.getKeyGroupRange()))
+ keyedStateHandle.getKeyGroupRange(),
+ getMaterializationID(keyedStateHandle)))
.collect(Collectors.toList());
}
+
+ private long getMaterializationID(KeyedStateHandle keyedStateHandle) {
+ if (keyedStateHandle instanceof IncrementalKeyedStateHandle) {
+ return ((IncrementalKeyedStateHandle) keyedStateHandle).getCheckpointId();
Review comment:
How about a straightforward `CheckpointStateHandle`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
}, {
"hash" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589",
"triggerID" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"triggerType" : "PUSH"
}, {
"hash" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29592",
"triggerID" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589)
* b811819772b2d2a5dc839ac8589c07fd9796ff1f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29592)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
}, {
"hash" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589",
"triggerID" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"triggerType" : "PUSH"
}, {
"hash" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29592",
"triggerID" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"triggerType" : "PUSH"
}, {
"hash" : "6bd06df926e13c3dc4788242316f600711ccb418",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29595",
"triggerID" : "6bd06df926e13c3dc4788242316f600711ccb418",
"triggerType" : "PUSH"
}, {
"hash" : "ef6989575ebe74f5cba3cd5f6c363f465eaba709",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29801",
"triggerID" : "ef6989575ebe74f5cba3cd5f6c363f465eaba709",
"triggerType" : "PUSH"
}, {
"hash" : "ac5235e16ec43f58d558472e9f2bc6f8512336eb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30027",
"triggerID" : "ac5235e16ec43f58d558472e9f2bc6f8512336eb",
"triggerType" : "PUSH"
}, {
"hash" : "06969c07178c598b4bd39fbf88385b1b0638e3a6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30048",
"triggerID" : "06969c07178c598b4bd39fbf88385b1b0638e3a6",
"triggerType" : "PUSH"
}, {
"hash" : "dee3a8cf9a282bc17924ccb9393d0592e4cd2011",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dee3a8cf9a282bc17924ccb9393d0592e4cd2011",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef6989575ebe74f5cba3cd5f6c363f465eaba709 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29801)
* ac5235e16ec43f58d558472e9f2bc6f8512336eb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30027)
* 06969c07178c598b4bd39fbf88385b1b0638e3a6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30048)
* dee3a8cf9a282bc17924ccb9393d0592e4cd2011 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
}, {
"hash" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589",
"triggerID" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"triggerType" : "PUSH"
}, {
"hash" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29592",
"triggerID" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"triggerType" : "PUSH"
}, {
"hash" : "6bd06df926e13c3dc4788242316f600711ccb418",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29595",
"triggerID" : "6bd06df926e13c3dc4788242316f600711ccb418",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b811819772b2d2a5dc839ac8589c07fd9796ff1f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29592)
* 6bd06df926e13c3dc4788242316f600711ccb418 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29595)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a change in pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #18382:
URL: https://github.com/apache/flink/pull/18382#discussion_r787869565
##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java
##########
@@ -453,7 +465,10 @@ public void notifyCheckpointAborted(long checkpointId) throws Exception {
// This might change if the log ownership changes (the method won't likely be needed).
stateChangelogWriter.reset(lastUploadedFrom, lastUploadedTo);
}
- keyedStateBackend.notifyCheckpointAborted(checkpointId);
+ Long materializationID = materializationIdByCheckpointId.remove(checkpointId);
+ if (materializationID != null) {
Review comment:
Maybe removing the abort call directly is not good. We should better call this finally at appropriate moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
}, {
"hash" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589",
"triggerID" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"triggerType" : "PUSH"
}, {
"hash" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88928763224da2a95afb2811ecf3311232a2c115 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587)
* b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589)
* b811819772b2d2a5dc839ac8589c07fd9796ff1f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
}, {
"hash" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589",
"triggerID" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"triggerType" : "PUSH"
}, {
"hash" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29592",
"triggerID" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"triggerType" : "PUSH"
}, {
"hash" : "6bd06df926e13c3dc4788242316f600711ccb418",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29595",
"triggerID" : "6bd06df926e13c3dc4788242316f600711ccb418",
"triggerType" : "PUSH"
}, {
"hash" : "ef6989575ebe74f5cba3cd5f6c363f465eaba709",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29801",
"triggerID" : "ef6989575ebe74f5cba3cd5f6c363f465eaba709",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef6989575ebe74f5cba3cd5f6c363f465eaba709 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29801)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [WIP][FLINK-25524][state/changelog] Fix checkpoint ID in completion notifications
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
}, {
"hash" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589",
"triggerID" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88928763224da2a95afb2811ecf3311232a2c115 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587)
* b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
}, {
"hash" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589",
"triggerID" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"triggerType" : "PUSH"
}, {
"hash" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29592",
"triggerID" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"triggerType" : "PUSH"
}, {
"hash" : "6bd06df926e13c3dc4788242316f600711ccb418",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bd06df926e13c3dc4788242316f600711ccb418",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b811819772b2d2a5dc839ac8589c07fd9796ff1f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29592)
* 6bd06df926e13c3dc4788242316f600711ccb418 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
}, {
"hash" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589",
"triggerID" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"triggerType" : "PUSH"
}, {
"hash" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29592",
"triggerID" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"triggerType" : "PUSH"
}, {
"hash" : "6bd06df926e13c3dc4788242316f600711ccb418",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29595",
"triggerID" : "6bd06df926e13c3dc4788242316f600711ccb418",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6bd06df926e13c3dc4788242316f600711ccb418 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29595)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
}, {
"hash" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589",
"triggerID" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"triggerType" : "PUSH"
}, {
"hash" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29592",
"triggerID" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88928763224da2a95afb2811ecf3311232a2c115 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587)
* b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589)
* b811819772b2d2a5dc839ac8589c07fd9796ff1f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29592)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
}, {
"hash" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589",
"triggerID" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"triggerType" : "PUSH"
}, {
"hash" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29592",
"triggerID" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"triggerType" : "PUSH"
}, {
"hash" : "6bd06df926e13c3dc4788242316f600711ccb418",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29595",
"triggerID" : "6bd06df926e13c3dc4788242316f600711ccb418",
"triggerType" : "PUSH"
}, {
"hash" : "ef6989575ebe74f5cba3cd5f6c363f465eaba709",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29801",
"triggerID" : "ef6989575ebe74f5cba3cd5f6c363f465eaba709",
"triggerType" : "PUSH"
}, {
"hash" : "ac5235e16ec43f58d558472e9f2bc6f8512336eb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30027",
"triggerID" : "ac5235e16ec43f58d558472e9f2bc6f8512336eb",
"triggerType" : "PUSH"
}, {
"hash" : "06969c07178c598b4bd39fbf88385b1b0638e3a6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30048",
"triggerID" : "06969c07178c598b4bd39fbf88385b1b0638e3a6",
"triggerType" : "PUSH"
}, {
"hash" : "dee3a8cf9a282bc17924ccb9393d0592e4cd2011",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30062",
"triggerID" : "dee3a8cf9a282bc17924ccb9393d0592e4cd2011",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef6989575ebe74f5cba3cd5f6c363f465eaba709 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29801)
* ac5235e16ec43f58d558472e9f2bc6f8512336eb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30027)
* 06969c07178c598b4bd39fbf88385b1b0638e3a6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30048)
* dee3a8cf9a282bc17924ccb9393d0592e4cd2011 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30062)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #18382:
URL: https://github.com/apache/flink/pull/18382#discussion_r788781449
##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogStateBackend.java
##########
@@ -272,7 +273,16 @@ public StateBackend configure(ReadableConfig config, ClassLoader classLoader)
: new ChangelogStateBackendHandleImpl(
singletonList(keyedStateHandle),
emptyList(),
- keyedStateHandle.getKeyGroupRange()))
+ keyedStateHandle.getKeyGroupRange(),
+ getMaterializationID(keyedStateHandle)))
.collect(Collectors.toList());
}
+
+ private long getMaterializationID(KeyedStateHandle keyedStateHandle) {
+ if (keyedStateHandle instanceof IncrementalKeyedStateHandle) {
+ return ((IncrementalKeyedStateHandle) keyedStateHandle).getCheckpointId();
Review comment:
I've added `CheckpointBoundKeyedStateHandle` as agreed offline, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
}, {
"hash" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589",
"triggerID" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"triggerType" : "PUSH"
}, {
"hash" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29592",
"triggerID" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"triggerType" : "PUSH"
}, {
"hash" : "6bd06df926e13c3dc4788242316f600711ccb418",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29595",
"triggerID" : "6bd06df926e13c3dc4788242316f600711ccb418",
"triggerType" : "PUSH"
}, {
"hash" : "ef6989575ebe74f5cba3cd5f6c363f465eaba709",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29801",
"triggerID" : "ef6989575ebe74f5cba3cd5f6c363f465eaba709",
"triggerType" : "PUSH"
}, {
"hash" : "ac5235e16ec43f58d558472e9f2bc6f8512336eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30027",
"triggerID" : "ac5235e16ec43f58d558472e9f2bc6f8512336eb",
"triggerType" : "PUSH"
}, {
"hash" : "06969c07178c598b4bd39fbf88385b1b0638e3a6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30048",
"triggerID" : "06969c07178c598b4bd39fbf88385b1b0638e3a6",
"triggerType" : "PUSH"
}, {
"hash" : "dee3a8cf9a282bc17924ccb9393d0592e4cd2011",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30062",
"triggerID" : "dee3a8cf9a282bc17924ccb9393d0592e4cd2011",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 06969c07178c598b4bd39fbf88385b1b0638e3a6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30048)
* dee3a8cf9a282bc17924ccb9393d0592e4cd2011 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30062)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [WIP][FLINK-25524][state/changelog] Fix checkpoint ID in completion notifications
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88928763224da2a95afb2811ecf3311232a2c115 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [WIP][FLINK-25524][state/changelog] Fix checkpoint ID in completion notifications
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
}, {
"hash" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88928763224da2a95afb2811ecf3311232a2c115 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587)
* b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [WIP][FLINK-25524][state/changelog] Fix checkpoint ID in completion notifications
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88928763224da2a95afb2811ecf3311232a2c115 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #18382:
URL: https://github.com/apache/flink/pull/18382#discussion_r787786651
##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java
##########
@@ -453,7 +465,10 @@ public void notifyCheckpointAborted(long checkpointId) throws Exception {
// This might change if the log ownership changes (the method won't likely be needed).
stateChangelogWriter.reset(lastUploadedFrom, lastUploadedTo);
}
- keyedStateBackend.notifyCheckpointAborted(checkpointId);
+ Long materializationID = materializationIdByCheckpointId.remove(checkpointId);
+ if (materializationID != null) {
Review comment:
I think you're right, although re-uploading will not do any harm.
I'll remove the abort call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18382: [WIP][FLINK-25524][state/changelog] Fix checkpoint ID in completion notifications
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88928763224da2a95afb2811ecf3311232a2c115 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
}, {
"hash" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589",
"triggerID" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"triggerType" : "PUSH"
}, {
"hash" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29592",
"triggerID" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88928763224da2a95afb2811ecf3311232a2c115 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587)
* b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589)
* b811819772b2d2a5dc839ac8589c07fd9796ff1f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29592)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #18382:
URL: https://github.com/apache/flink/pull/18382#discussion_r788780427
##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java
##########
@@ -453,7 +465,10 @@ public void notifyCheckpointAborted(long checkpointId) throws Exception {
// This might change if the log ownership changes (the method won't likely be needed).
stateChangelogWriter.reset(lastUploadedFrom, lastUploadedTo);
}
- keyedStateBackend.notifyCheckpointAborted(checkpointId);
+ Long materializationID = materializationIdByCheckpointId.remove(checkpointId);
+ if (materializationID != null) {
Review comment:
To summarize the offline discussion:
Pros of notifying: some backends might do GC
Cons of notifiying:
- there is low probability of abortion notification reaching backend (because of difference in intervals and cleanup on checkpoint completion)
- there is low probability of backends make good use of it (because it's delivered **after** snapshot is done; and backends must be resilient to missing notifications)
- there is added complexity and risk (please double check pre-marture notification and cleanup of maps)
I've added it in 862d28e7e2ff899a022d2f2e3da37ceaf149d31f but I'm still not sure whether it worth it.
PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
}, {
"hash" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589",
"triggerID" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"triggerType" : "PUSH"
}, {
"hash" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29592",
"triggerID" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"triggerType" : "PUSH"
}, {
"hash" : "6bd06df926e13c3dc4788242316f600711ccb418",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29595",
"triggerID" : "6bd06df926e13c3dc4788242316f600711ccb418",
"triggerType" : "PUSH"
}, {
"hash" : "ef6989575ebe74f5cba3cd5f6c363f465eaba709",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29801",
"triggerID" : "ef6989575ebe74f5cba3cd5f6c363f465eaba709",
"triggerType" : "PUSH"
}, {
"hash" : "ac5235e16ec43f58d558472e9f2bc6f8512336eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30027",
"triggerID" : "ac5235e16ec43f58d558472e9f2bc6f8512336eb",
"triggerType" : "PUSH"
}, {
"hash" : "06969c07178c598b4bd39fbf88385b1b0638e3a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30048",
"triggerID" : "06969c07178c598b4bd39fbf88385b1b0638e3a6",
"triggerType" : "PUSH"
}, {
"hash" : "dee3a8cf9a282bc17924ccb9393d0592e4cd2011",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30062",
"triggerID" : "dee3a8cf9a282bc17924ccb9393d0592e4cd2011",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dee3a8cf9a282bc17924ccb9393d0592e4cd2011 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30062)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #18382:
URL: https://github.com/apache/flink/pull/18382#discussion_r790615543
##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java
##########
@@ -441,7 +469,17 @@ public void notifyCheckpointComplete(long checkpointId) throws Exception {
// This might change if the log ownership changes (the method won't likely be needed).
stateChangelogWriter.confirm(lastUploadedFrom, lastUploadedTo);
}
- keyedStateBackend.notifyCheckpointComplete(checkpointId);
+ Long materializationID = materializationIdByCheckpointId.remove(checkpointId);
+ if (materializationID != null) {
+ keyedStateBackend.notifyCheckpointComplete(materializationID);
+ pendingMaterializationConfirmations.remove(materializationID);
Review comment:
Implemented in ac5235e16ec43f58d558472e9f2bc6f8512336eb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan merged pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
rkhachatryan merged pull request #18382:
URL: https://github.com/apache/flink/pull/18382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #18382:
URL: https://github.com/apache/flink/pull/18382#discussion_r787782846
##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogStateBackend.java
##########
@@ -272,7 +273,16 @@ public StateBackend configure(ReadableConfig config, ClassLoader classLoader)
: new ChangelogStateBackendHandleImpl(
singletonList(keyedStateHandle),
emptyList(),
- keyedStateHandle.getKeyGroupRange()))
+ keyedStateHandle.getKeyGroupRange(),
+ getMaterializationID(keyedStateHandle)))
.collect(Collectors.toList());
}
+
+ private long getMaterializationID(KeyedStateHandle keyedStateHandle) {
+ if (keyedStateHandle instanceof IncrementalKeyedStateHandle) {
+ return ((IncrementalKeyedStateHandle) keyedStateHandle).getCheckpointId();
Review comment:
WDYT about `CheckpointBoundKeyedStateHandle` name for this interface?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a change in pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #18382:
URL: https://github.com/apache/flink/pull/18382#discussion_r787749960
##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java
##########
@@ -453,7 +465,10 @@ public void notifyCheckpointAborted(long checkpointId) throws Exception {
// This might change if the log ownership changes (the method won't likely be needed).
stateChangelogWriter.reset(lastUploadedFrom, lastUploadedTo);
}
- keyedStateBackend.notifyCheckpointAborted(checkpointId);
+ Long materializationID = materializationIdByCheckpointId.remove(checkpointId);
+ if (materializationID != null) {
Review comment:
I do not think this logic is correct. Take materialization id as 1 for example, maybe chk-11 did not complete, but chk-12 could complete to involve the materialization-1. If we abort the materialization-1 at chk-11, RocksDB state backend would have to reupload at next materialization.
##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogStateBackend.java
##########
@@ -272,7 +273,16 @@ public StateBackend configure(ReadableConfig config, ClassLoader classLoader)
: new ChangelogStateBackendHandleImpl(
singletonList(keyedStateHandle),
emptyList(),
- keyedStateHandle.getKeyGroupRange()))
+ keyedStateHandle.getKeyGroupRange(),
+ getMaterializationID(keyedStateHandle)))
.collect(Collectors.toList());
}
+
+ private long getMaterializationID(KeyedStateHandle keyedStateHandle) {
+ if (keyedStateHandle instanceof IncrementalKeyedStateHandle) {
+ return ((IncrementalKeyedStateHandle) keyedStateHandle).getCheckpointId();
Review comment:
I think we can introduce a new interface to include `getCheckpointId()` instead of still use the `IncrementalKeyedStateHandle`, so that all 3rd-party state handles could extend that handle to make it compatiable with changelog state-backend.
##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java
##########
@@ -586,19 +606,20 @@ private ChangelogSnapshotState completeRestore(
LOG.info("Starting materialization from {} : {}", lastMaterializedTo, upTo);
+ // This ID is not needed for materialization; But since we are re-using the
+ // streamFactory that is designed for state backend snapshot, which requires unique
+ // checkpoint ID. A faked materialized Id is provided here.
+ // TODO: implement its own streamFactory.
Review comment:
I think this TODO for a stream factory should be commented on the `streamFactory`.
##########
File path: flink-state-backends/flink-statebackend-changelog/src/test/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackendTest.java
##########
@@ -0,0 +1,124 @@
+package org.apache.flink.state.changelog;
Review comment:
I think in general, we would have the license on top of each file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [WIP][FLINK-25524][state/changelog] Fix checkpoint ID in completion notifications
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
}, {
"hash" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88928763224da2a95afb2811ecf3311232a2c115 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587)
* b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
}, {
"hash" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589",
"triggerID" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"triggerType" : "PUSH"
}, {
"hash" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29592",
"triggerID" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b811819772b2d2a5dc839ac8589c07fd9796ff1f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29592)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a change in pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #18382:
URL: https://github.com/apache/flink/pull/18382#discussion_r790293553
##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java
##########
@@ -441,7 +469,17 @@ public void notifyCheckpointComplete(long checkpointId) throws Exception {
// This might change if the log ownership changes (the method won't likely be needed).
stateChangelogWriter.confirm(lastUploadedFrom, lastUploadedTo);
}
- keyedStateBackend.notifyCheckpointComplete(checkpointId);
+ Long materializationID = materializationIdByCheckpointId.remove(checkpointId);
+ if (materializationID != null) {
+ keyedStateBackend.notifyCheckpointComplete(materializationID);
+ pendingMaterializationConfirmations.remove(materializationID);
Review comment:
I think we can introduce another `lastConfirmedMaterizationId` (simliar like `lastCheckpointId`), we only notifyCheckpoint complete to wrapped state backend if current materilzation id is larger than `lastConfirmedMaterizationId`. If so, we can also avoid to update `pendingMaterializationConfirmations` each time as we don't need to record checkpoints if this materilzation id is equal to `lastConfirmedMaterizationId`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
}, {
"hash" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589",
"triggerID" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"triggerType" : "PUSH"
}, {
"hash" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29592",
"triggerID" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"triggerType" : "PUSH"
}, {
"hash" : "6bd06df926e13c3dc4788242316f600711ccb418",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29595",
"triggerID" : "6bd06df926e13c3dc4788242316f600711ccb418",
"triggerType" : "PUSH"
}, {
"hash" : "ef6989575ebe74f5cba3cd5f6c363f465eaba709",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29801",
"triggerID" : "ef6989575ebe74f5cba3cd5f6c363f465eaba709",
"triggerType" : "PUSH"
}, {
"hash" : "ac5235e16ec43f58d558472e9f2bc6f8512336eb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ac5235e16ec43f58d558472e9f2bc6f8512336eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef6989575ebe74f5cba3cd5f6c363f465eaba709 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29801)
* ac5235e16ec43f58d558472e9f2bc6f8512336eb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #18382:
URL: https://github.com/apache/flink/pull/18382#discussion_r790613550
##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java
##########
@@ -441,7 +469,17 @@ public void notifyCheckpointComplete(long checkpointId) throws Exception {
// This might change if the log ownership changes (the method won't likely be needed).
stateChangelogWriter.confirm(lastUploadedFrom, lastUploadedTo);
}
- keyedStateBackend.notifyCheckpointComplete(checkpointId);
+ Long materializationID = materializationIdByCheckpointId.remove(checkpointId);
+ if (materializationID != null) {
+ keyedStateBackend.notifyCheckpointComplete(materializationID);
+ pendingMaterializationConfirmations.remove(materializationID);
Review comment:
As discussed offline, I'll use `pendingMaterializationConfirmations` to prevent double notifications.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1020209670
Thanks for reviewing!
I'll merge the PR after squashing commits and rebasing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan merged pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
rkhachatryan merged pull request #18382:
URL: https://github.com/apache/flink/pull/18382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
}, {
"hash" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589",
"triggerID" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"triggerType" : "PUSH"
}, {
"hash" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29592",
"triggerID" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"triggerType" : "PUSH"
}, {
"hash" : "6bd06df926e13c3dc4788242316f600711ccb418",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29595",
"triggerID" : "6bd06df926e13c3dc4788242316f600711ccb418",
"triggerType" : "PUSH"
}, {
"hash" : "ef6989575ebe74f5cba3cd5f6c363f465eaba709",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29801",
"triggerID" : "ef6989575ebe74f5cba3cd5f6c363f465eaba709",
"triggerType" : "PUSH"
}, {
"hash" : "ac5235e16ec43f58d558472e9f2bc6f8512336eb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30027",
"triggerID" : "ac5235e16ec43f58d558472e9f2bc6f8512336eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef6989575ebe74f5cba3cd5f6c363f465eaba709 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29801)
* ac5235e16ec43f58d558472e9f2bc6f8512336eb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30027)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
}, {
"hash" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589",
"triggerID" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"triggerType" : "PUSH"
}, {
"hash" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29592",
"triggerID" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"triggerType" : "PUSH"
}, {
"hash" : "6bd06df926e13c3dc4788242316f600711ccb418",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29595",
"triggerID" : "6bd06df926e13c3dc4788242316f600711ccb418",
"triggerType" : "PUSH"
}, {
"hash" : "ef6989575ebe74f5cba3cd5f6c363f465eaba709",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ef6989575ebe74f5cba3cd5f6c363f465eaba709",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6bd06df926e13c3dc4788242316f600711ccb418 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29595)
* ef6989575ebe74f5cba3cd5f6c363f465eaba709 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
}, {
"hash" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589",
"triggerID" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"triggerType" : "PUSH"
}, {
"hash" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29592",
"triggerID" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"triggerType" : "PUSH"
}, {
"hash" : "6bd06df926e13c3dc4788242316f600711ccb418",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29595",
"triggerID" : "6bd06df926e13c3dc4788242316f600711ccb418",
"triggerType" : "PUSH"
}, {
"hash" : "ef6989575ebe74f5cba3cd5f6c363f465eaba709",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29801",
"triggerID" : "ef6989575ebe74f5cba3cd5f6c363f465eaba709",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6bd06df926e13c3dc4788242316f600711ccb418 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29595)
* ef6989575ebe74f5cba3cd5f6c363f465eaba709 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29801)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18382: [WIP][FLINK-25524][state/changelog] Fix checkpoint ID in completion notifications
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014705641
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 88928763224da2a95afb2811ecf3311232a2c115 (Mon Jan 17 16:18:30 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #18382:
URL: https://github.com/apache/flink/pull/18382#discussion_r788780719
##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java
##########
@@ -453,7 +465,10 @@ public void notifyCheckpointAborted(long checkpointId) throws Exception {
// This might change if the log ownership changes (the method won't likely be needed).
stateChangelogWriter.reset(lastUploadedFrom, lastUploadedTo);
}
- keyedStateBackend.notifyCheckpointAborted(checkpointId);
+ Long materializationID = materializationIdByCheckpointId.remove(checkpointId);
+ if (materializationID != null) {
Review comment:
To summarize the offline discussion:
Pros of notifying: some backends might do GC
Cons of notifiying:
- there is low probability of abortion notification reaching backend (because of difference in intervals and cleanup on checkpoint completion)
- there is low probability of backends make good use of it (because it's delivered **after** snapshot is done; and backends must be resilient to missing notifications)
- there is added complexity and risk (please double check pre-marture notification and cleanup of maps)
I've added it in 862d28e7e2ff899a022d2f2e3da37ceaf149d31f but I'm still not sure whether it worth it.
PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
}, {
"hash" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589",
"triggerID" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"triggerType" : "PUSH"
}, {
"hash" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29592",
"triggerID" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"triggerType" : "PUSH"
}, {
"hash" : "6bd06df926e13c3dc4788242316f600711ccb418",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29595",
"triggerID" : "6bd06df926e13c3dc4788242316f600711ccb418",
"triggerType" : "PUSH"
}, {
"hash" : "ef6989575ebe74f5cba3cd5f6c363f465eaba709",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29801",
"triggerID" : "ef6989575ebe74f5cba3cd5f6c363f465eaba709",
"triggerType" : "PUSH"
}, {
"hash" : "ac5235e16ec43f58d558472e9f2bc6f8512336eb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30027",
"triggerID" : "ac5235e16ec43f58d558472e9f2bc6f8512336eb",
"triggerType" : "PUSH"
}, {
"hash" : "06969c07178c598b4bd39fbf88385b1b0638e3a6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30048",
"triggerID" : "06969c07178c598b4bd39fbf88385b1b0638e3a6",
"triggerType" : "PUSH"
}, {
"hash" : "dee3a8cf9a282bc17924ccb9393d0592e4cd2011",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30062",
"triggerID" : "dee3a8cf9a282bc17924ccb9393d0592e4cd2011",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ac5235e16ec43f58d558472e9f2bc6f8512336eb Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30027)
* 06969c07178c598b4bd39fbf88385b1b0638e3a6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30048)
* dee3a8cf9a282bc17924ccb9393d0592e4cd2011 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30062)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
}, {
"hash" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589",
"triggerID" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"triggerType" : "PUSH"
}, {
"hash" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29592",
"triggerID" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"triggerType" : "PUSH"
}, {
"hash" : "6bd06df926e13c3dc4788242316f600711ccb418",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29595",
"triggerID" : "6bd06df926e13c3dc4788242316f600711ccb418",
"triggerType" : "PUSH"
}, {
"hash" : "ef6989575ebe74f5cba3cd5f6c363f465eaba709",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29801",
"triggerID" : "ef6989575ebe74f5cba3cd5f6c363f465eaba709",
"triggerType" : "PUSH"
}, {
"hash" : "ac5235e16ec43f58d558472e9f2bc6f8512336eb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30027",
"triggerID" : "ac5235e16ec43f58d558472e9f2bc6f8512336eb",
"triggerType" : "PUSH"
}, {
"hash" : "06969c07178c598b4bd39fbf88385b1b0638e3a6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30048",
"triggerID" : "06969c07178c598b4bd39fbf88385b1b0638e3a6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef6989575ebe74f5cba3cd5f6c363f465eaba709 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29801)
* ac5235e16ec43f58d558472e9f2bc6f8512336eb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30027)
* 06969c07178c598b4bd39fbf88385b1b0638e3a6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30048)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88928763224da2a95afb2811ecf3311232a2c115",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29587",
"triggerID" : "88928763224da2a95afb2811ecf3311232a2c115",
"triggerType" : "PUSH"
}, {
"hash" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29589",
"triggerID" : "b5d1edb85053fb7371c884d2a8f3a7b0b0f64f97",
"triggerType" : "PUSH"
}, {
"hash" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29592",
"triggerID" : "b811819772b2d2a5dc839ac8589c07fd9796ff1f",
"triggerType" : "PUSH"
}, {
"hash" : "6bd06df926e13c3dc4788242316f600711ccb418",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29595",
"triggerID" : "6bd06df926e13c3dc4788242316f600711ccb418",
"triggerType" : "PUSH"
}, {
"hash" : "ef6989575ebe74f5cba3cd5f6c363f465eaba709",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29801",
"triggerID" : "ef6989575ebe74f5cba3cd5f6c363f465eaba709",
"triggerType" : "PUSH"
}, {
"hash" : "ac5235e16ec43f58d558472e9f2bc6f8512336eb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30027",
"triggerID" : "ac5235e16ec43f58d558472e9f2bc6f8512336eb",
"triggerType" : "PUSH"
}, {
"hash" : "06969c07178c598b4bd39fbf88385b1b0638e3a6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "06969c07178c598b4bd39fbf88385b1b0638e3a6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef6989575ebe74f5cba3cd5f6c363f465eaba709 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29801)
* ac5235e16ec43f58d558472e9f2bc6f8512336eb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30027)
* 06969c07178c598b4bd39fbf88385b1b0638e3a6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18382:
URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org