You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/02/14 22:00:25 UTC
[GitHub] [maven-dependency-plugin] slawekjaranowski opened a new pull request #196: [MDEP-789] Improve documentation of analyze - Non-test scoped
slawekjaranowski opened a new pull request #196:
URL: https://github.com/apache/maven-dependency-plugin/pull/196
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MDEP) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MDEP-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MDEP-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] slawekjaranowski merged pull request #196: [MDEP-789] Improve documentation of analyze - Non-test scoped
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged pull request #196:
URL: https://github.com/apache/maven-dependency-plugin/pull/196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] slawekjaranowski commented on pull request #196: [MDEP-789] Improve documentation of analyze - Non-test scoped
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #196:
URL: https://github.com/apache/maven-dependency-plugin/pull/196#issuecomment-1040545757
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] slawekjaranowski commented on pull request #196: [MDEP-789] Improve documentation of analyze - Non-test scoped
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #196:
URL: https://github.com/apache/maven-dependency-plugin/pull/196#issuecomment-1040545757
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] elharo commented on a change in pull request #196: [MDEP-789] Improve documentation of analyze - Non-test scoped
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #196:
URL: https://github.com/apache/maven-dependency-plugin/pull/196#discussion_r806759679
##########
File path: src/site/apt/examples/exclude-dependencies-from-dependency-analysis.apt.vm
##########
@@ -34,10 +34,11 @@ Exclude dependencies from dependency analysis
that contain annotations and the byte code analysis is unable to
determine whether a jar is actually required or not.
- The plugin can then be configured to ignore these dependencies in
- either "declared but unused" or "undeclared but used" case or in
- both simultaneously. See the following POM configuration for an
- example:
+ The plugin can then be configured to ignore dependencies in
Review comment:
in --> that are
##########
File path: src/site/apt/examples/exclude-dependencies-from-dependency-analysis.apt.vm
##########
@@ -57,7 +58,7 @@ Exclude dependencies from dependency analysis
<configuration>
<failOnWarning>true</failOnWarning>
- <!-- ignore jsr305 for both "used but undeclared" and "declared but unused" -->
+ <!-- ignore jsr305 for "used but undeclared", "declared but unused" and "non-test scoped" -->
Review comment:
comma after unused"
##########
File path: src/site/apt/examples/exclude-dependencies-from-dependency-analysis.apt.vm
##########
@@ -34,10 +34,11 @@ Exclude dependencies from dependency analysis
that contain annotations and the byte code analysis is unable to
determine whether a jar is actually required or not.
- The plugin can then be configured to ignore these dependencies in
- either "declared but unused" or "undeclared but used" case or in
- both simultaneously. See the following POM configuration for an
- example:
+ The plugin can then be configured to ignore dependencies in
+ "declared but unused", "undeclared but used" and "non-test scoped"
Review comment:
comma after used"
##########
File path: src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java
##########
@@ -167,7 +169,7 @@
/**
* List of dependencies that will be ignored. Any dependency on this list will be excluded from the "declared but
- * unused" and the "used but undeclared" list. The filter syntax is:
+ * unused", the "used but undeclared" and the "non-test scoped" list. The filter syntax is:
Review comment:
comma after undeclared"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] elharo commented on a change in pull request #196: [MDEP-789] Improve documentation of analyze - Non-test scoped
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #196:
URL: https://github.com/apache/maven-dependency-plugin/pull/196#discussion_r806759679
##########
File path: src/site/apt/examples/exclude-dependencies-from-dependency-analysis.apt.vm
##########
@@ -34,10 +34,11 @@ Exclude dependencies from dependency analysis
that contain annotations and the byte code analysis is unable to
determine whether a jar is actually required or not.
- The plugin can then be configured to ignore these dependencies in
- either "declared but unused" or "undeclared but used" case or in
- both simultaneously. See the following POM configuration for an
- example:
+ The plugin can then be configured to ignore dependencies in
Review comment:
in --> that are
##########
File path: src/site/apt/examples/exclude-dependencies-from-dependency-analysis.apt.vm
##########
@@ -57,7 +58,7 @@ Exclude dependencies from dependency analysis
<configuration>
<failOnWarning>true</failOnWarning>
- <!-- ignore jsr305 for both "used but undeclared" and "declared but unused" -->
+ <!-- ignore jsr305 for "used but undeclared", "declared but unused" and "non-test scoped" -->
Review comment:
comma after unused"
##########
File path: src/site/apt/examples/exclude-dependencies-from-dependency-analysis.apt.vm
##########
@@ -34,10 +34,11 @@ Exclude dependencies from dependency analysis
that contain annotations and the byte code analysis is unable to
determine whether a jar is actually required or not.
- The plugin can then be configured to ignore these dependencies in
- either "declared but unused" or "undeclared but used" case or in
- both simultaneously. See the following POM configuration for an
- example:
+ The plugin can then be configured to ignore dependencies in
+ "declared but unused", "undeclared but used" and "non-test scoped"
Review comment:
comma after used"
##########
File path: src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java
##########
@@ -167,7 +169,7 @@
/**
* List of dependencies that will be ignored. Any dependency on this list will be excluded from the "declared but
- * unused" and the "used but undeclared" list. The filter syntax is:
+ * unused", the "used but undeclared" and the "non-test scoped" list. The filter syntax is:
Review comment:
comma after undeclared"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org