You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/10/21 21:10:45 UTC
[GitHub] [tvm] janetsc opened a new pull request, #13174: [Hexagon] [runtime] Allow creation of thread manager without hardware resources
janetsc opened a new pull request, #13174:
URL: https://github.com/apache/tvm/pull/13174
This allows the creation of a thread manager with optional hardware resources. This allows us to create unit tests without hardware resources (and will fix the test instability we've seen recently, as all tests were using the global thread manager and things could be in an unknown state.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13174: [Hexagon] [runtime] Allow creation of thread manager without hardware resources
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13174:
URL: https://github.com/apache/tvm/pull/13174#issuecomment-1287439821
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati merged pull request #13174: [Hexagon] [runtime] Allow creation of thread manager without hardware resources
Posted by GitBox <gi...@apache.org>.
driazati merged PR #13174:
URL: https://github.com/apache/tvm/pull/13174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] adstraw commented on a diff in pull request #13174: [Hexagon] [runtime] Allow creation of thread manager without hardware resources
Posted by GitBox <gi...@apache.org>.
adstraw commented on code in PR #13174:
URL: https://github.com/apache/tvm/pull/13174#discussion_r1002258699
##########
tests/cpp-runtime/hexagon/hexagon_thread_manager_tests.cc:
##########
@@ -54,6 +55,15 @@ TEST_F(HexagonThreadManagerTest, ctor_errors) {
ASSERT_THROW(HexagonThreadManager(6, stack_size, 9), InternalError);
// pipe too big
ASSERT_THROW(HexagonThreadManager(6, stack_size, 0x10000000), InternalError);
+ // hw resources count doesn't match thread count
+ ASSERT_THROW(HexagonThreadManager(6, stack_size, pipe_size, {DMA_0}), InternalError);
+ // hw resources doesn't match specific supported configuration
Review Comment:
We should come back and revisit this. Having this _very_ strict specification of hardware resources is probably not what we want long term. Let's see if we can make this a little more flexible going forward. That said, I am OK with this PR as an interim step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org