You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/09/04 13:51:02 UTC
[GitHub] [flink] aljoscha commented on a change in pull request #9607:
[FLINK-13946] Remove job session related code from ExecutionEnvironment
aljoscha commented on a change in pull request #9607: [FLINK-13946] Remove job session related code from ExecutionEnvironment
URL: https://github.com/apache/flink/pull/9607#discussion_r320769875
##########
File path: flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java
##########
@@ -77,11 +70,11 @@
// ------------------------------------------------------------------------
public LocalExecutor() {
- this(null);
+ this(new Configuration());
}
public LocalExecutor(Configuration conf) {
- this.baseConfiguration = conf != null ? conf : new Configuration();
+ this.baseConfiguration = checkNotNull(conf);
Review comment:
I think you can only omit the `checkNotNull()` calls when your build system verifies that the `@Nonnull` contract is actually followed. Outside code, that is calling your function might still pass in a `null`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services