You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2020/05/22 03:36:09 UTC

[GitHub] [bigtop] iwasakims commented on a change in pull request #641: BIGTOP-3358: get_roles() function should fail if a component is not in roles_map

iwasakims commented on a change in pull request #641:
URL: https://github.com/apache/bigtop/pull/641#discussion_r429025896



##########
File path: bigtop-deploy/puppet/modules/bigtop-util/lib/puppet/parser/functions/get_roles.rb
##########
@@ -54,6 +54,8 @@
           temp_roles = component_map[role_type]
           roles.concat(temp_roles)
         end
+      else
+	fail Puppet::ParseError, "get_roles(): No such component in roles_map. #{component}"

Review comment:
       should be whitespace instead of tab.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org