You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "zwoop (via GitHub)" <gi...@apache.org> on 2023/11/04 17:22:39 UTC
[PR] Fixes Cripts compilation on gcc platforms [trafficserver]
zwoop opened a new pull request, #10729:
URL: https://github.com/apache/trafficserver/pull/10729
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixes Cripts compilation on gcc platforms [trafficserver]
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop merged PR #10729:
URL: https://github.com/apache/trafficserver/pull/10729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixes Cripts compilation on gcc platforms [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on code in PR #10729:
URL: https://github.com/apache/trafficserver/pull/10729#discussion_r1384159323
##########
example/cripts/example1.cc:
##########
@@ -27,7 +27,7 @@ static Matcher::Range::IP CRIPT_ALLOW({"192.168.201.0/24", "10.0.0.0/8"});
// This is called only when the plugin is initialized
do_init()
{
- TSDebug("Cript", "Hello, example1 plugin is being initialized");
+ // TSDebug("Cript", "Hello, example1 plugin is being initialized");
Review Comment:
As mentioned in PR/issue meeting: from TSDebug to dbgctl eventually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixes Cripts compilation on gcc platforms [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on code in PR #10729:
URL: https://github.com/apache/trafficserver/pull/10729#discussion_r1384147738
##########
example/cripts/example1.cc:
##########
@@ -27,7 +27,7 @@ static Matcher::Range::IP CRIPT_ALLOW({"192.168.201.0/24", "10.0.0.0/8"});
// This is called only when the plugin is initialized
do_init()
{
- TSDebug("Cript", "Hello, example1 plugin is being initialized");
+ // TSDebug("Cript", "Hello, example1 plugin is being initialized");
Review Comment:
TSDebug statements have to be commented out to get gcc builds to work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org