You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/10/22 06:40:24 UTC

[GitHub] [hudi] dongkelun commented on a change in pull request #3746: [HUDI-2515] Add close when producing records failed

dongkelun commented on a change in pull request #3746:
URL: https://github.com/apache/hudi/pull/3746#discussion_r734272106



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/util/ParquetReaderIterator.java
##########
@@ -66,8 +72,13 @@ public T next() {
       T retVal = this.next;
       this.next = parquetReader.read();
       return retVal;
-    } catch (IOException io) {
-      throw new HoodieIOException("unable to read next record from parquet file ", io);
+    } catch (Exception e) {
+      try {
+        close();
+      } catch (IOException io) {
+        io.printStackTrace();
+      }

Review comment:
       @yihua ok, modified




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org