[GitHub] [hive] pvary commented on a change in pull request #1998: HIVE-24802: Show operation log at webui

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #1998:
URL: https://github.com/apache/hive/pull/1998#discussion_r633086123



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/session/OperationLog.java
##########
@@ -73,10 +74,10 @@ public OperationLog(String name, File file, HiveConf hiveConf) {
       opLoggingLevel = LoggingLevel.UNKNOWN;
     }
 
+    isRemoveLogs = hiveConf.getBoolVar(HiveConf.ConfVars.HIVE_TESTING_REMOVE_LOGS);

Review comment:
       I would rather keep these configurations independent:
   - `HIVE_TESTING_REMOVE_LOGS`
   - `HIVE_SERVER2_HISTORIC_OPERATION_LOG_ENABLED`
   
   And if any of them are set to true, then do not remove the logs




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org