[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #1022: [core] Introduce consume-id for retore consuming and reserve snapshot

["JingsongLi (via GitHub)" <gi...@apache.org>]

JingsongLi commented on code in PR #1022:
URL: https://github.com/apache/incubator-paimon/pull/1022#discussion_r1177299759


##########
paimon-core/src/main/java/org/apache/paimon/table/source/AbstractInnerTableScan.java:
##########
@@ -65,6 +69,16 @@ protected StartingScanner createStartingScanner(boolean isStreaming) {
             return new ContinuousCompactorStartingScanner();
         }
 
+        // read from consumer id
+        String consumerId = options.consumerId();

Review Comment:
   I think if the relevant content is recorded inside the state, it should not be read from the consumer file and should be trusted in the state.
   Do you think something bad will happen?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org