You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2023/09/19 05:51:39 UTC
[spark] branch branch-3.4 updated: [SPARK-45210][DOCS][3.4] Switch languages consistently across docs for all code snippets (Spark 3.4 and below)
This is an automated email from the ASF dual-hosted git repository.
gurwls223 pushed a commit to branch branch-3.4
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-3.4 by this push:
new 796d8785c61 [SPARK-45210][DOCS][3.4] Switch languages consistently across docs for all code snippets (Spark 3.4 and below)
796d8785c61 is described below
commit 796d8785c61e09d1098350657fd44707763687db
Author: Hyukjin Kwon <gu...@apache.org>
AuthorDate: Tue Sep 19 14:51:27 2023 +0900
[SPARK-45210][DOCS][3.4] Switch languages consistently across docs for all code snippets (Spark 3.4 and below)
### What changes were proposed in this pull request?
This PR proposes to recover the availity of switching languages consistently across docs for all code snippets in Spark 3.4 and below by using the proper class selector in the JQuery. Previously the selector was a string `.nav-link tab_python` which did not comply multiple class selection: https://www.w3.org/TR/CSS21/selector.html#class-html. I assume it worked as a legacy behaviour somewhere. Now it uses the standard way `.nav-link.tab_python`.
Note that https://github.com/apache/spark/pull/42657 works because there's only single class assigned (after we refactored the site at https://github.com/apache/spark/pull/40269)
### Why are the changes needed?
This is a regression in our documentation site.
### Does this PR introduce _any_ user-facing change?
Yes, once you click the language tab, it will apply to the examples in the whole page.
### How was this patch tested?
Manually tested after building the site.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #42989 from HyukjinKwon/SPARK-45210.
Authored-by: Hyukjin Kwon <gu...@apache.org>
Signed-off-by: Hyukjin Kwon <gu...@apache.org>
---
docs/js/main.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/js/main.js b/docs/js/main.js
index 968097c8041..07df2541f74 100755
--- a/docs/js/main.js
+++ b/docs/js/main.js
@@ -63,7 +63,7 @@ function codeTabs() {
// while retaining the scroll position
e.preventDefault();
var scrollOffset = $(this).offset().top - $(document).scrollTop();
- $("." + $(this).attr('class')).tab('show');
+ $("." + $(this).attr('class').split(" ").join(".")).tab('show');
$(document).scrollTop($(this).offset().top - scrollOffset);
});
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org