You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2016/02/29 20:43:01 UTC

Re: Review Request 44110: Updated flag examples to refer to /metrics/snapshot instead of stats.json.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44110/
-----------------------------------------------------------

(Updated Feb. 29, 2016, 7:43 p.m.)


Review request for mesos, Alexander Rojas and Vinod Kone.


Summary (updated)
-----------------

Updated flag examples to refer to /metrics/snapshot instead of stats.json.


Bugs: MESOS-4509
    https://issues.apache.org/jira/browse/MESOS-4509


Repository: mesos


Description (updated)
-------

Updated flag examples to refer to /snapshot instead of deprecated stats.json.


Diffs
-----

  docs/configuration.md 2353e78a80548b63f871c52e840ffe2fe869f4d7 
  src/master/flags.cpp 60e085bd5c6689adb625a736edc76e814860ea7d 
  src/slave/flags.cpp 1c6a87b670efde2deab4d6e3f24fd6eb3704a47d 

Diff: https://reviews.apache.org/r/44110/diff/


Testing
-------

make test + manually checked the flags example.


Thanks,

Joerg Schad


Re: Review Request 44110: Updated flag examples to refer to /metrics/snapshot instead of stats.json.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44110/#review121502
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Feb. 29, 2016, 7:43 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44110/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2016, 7:43 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Vinod Kone.
> 
> 
> Bugs: MESOS-4509
>     https://issues.apache.org/jira/browse/MESOS-4509
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated flag examples to refer to /snapshot instead of deprecated stats.json.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 2353e78a80548b63f871c52e840ffe2fe869f4d7 
>   src/master/flags.cpp 60e085bd5c6689adb625a736edc76e814860ea7d 
>   src/slave/flags.cpp 1c6a87b670efde2deab4d6e3f24fd6eb3704a47d 
> 
> Diff: https://reviews.apache.org/r/44110/diff/
> 
> 
> Testing
> -------
> 
> make test + manually checked the flags example.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 44110: Updated flag examples to refer to /metrics/snapshot instead of stats.json.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44110/
-----------------------------------------------------------

(Updated March 1, 2016, 9:39 p.m.)


Review request for mesos, Alexander Rojas and Vinod Kone.


Bugs: MESOS-4817
    https://issues.apache.org/jira/browse/MESOS-4817


Repository: mesos


Description
-------

Updated flag examples to refer to /snapshot instead of deprecated stats.json.


Diffs
-----

  docs/configuration.md 2353e78a80548b63f871c52e840ffe2fe869f4d7 
  src/master/flags.cpp 60e085bd5c6689adb625a736edc76e814860ea7d 
  src/slave/flags.cpp 1c6a87b670efde2deab4d6e3f24fd6eb3704a47d 

Diff: https://reviews.apache.org/r/44110/diff/


Testing
-------

make test + manually checked the flags example.


Thanks,

Joerg Schad