You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/12 10:32:48 UTC

[GitHub] [incubator-nuttx] zhhyu7 opened a new pull request, #7291: usrsock: Correct some status exceptions in non-blocking mode usrsock connect

zhhyu7 opened a new pull request, #7291:
URL: https://github.com/apache/incubator-nuttx/pull/7291

   ## Summary
   Correct some status exceptions in non-blocking mode usrsock connect
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #7291: usrsock: Correct some status exceptions in non-blocking mode usrsock connect

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #7291:
URL: https://github.com/apache/incubator-nuttx/pull/7291#issuecomment-1275954028

   @zhhyu7 
   
   ```
   NuttShell (NSH) NuttX-10.3.0-RC0
   nsh> uname -a
   NuttX  10.3.0-RC0 2861124366-dirty Oct 12 2022 19:36:41 sim sim
   nsh> usrsocktest
   Starting unit-tests...
   Testing group "char_dev" =>
   	Group "char_dev": [OK]
   Testing group "no_daemon" =>
   	Group "no_daemon": [OK]
   Testing group "basic_daemon" =>
   	Group "basic_daemon": [OK]
   Testing group "basic_connect" =>
   	Group "basic_connect": [OK]
   Testing group "basic_connect_delay" =>
   	Group "basic_connect_delay": [OK]
   Testing group "no_block_connect" =>
   	Group "no_block_connect": [OK]
   Testing group "basic_send" =>
   	Group "basic_send": [OK]
   Testing group "no_block_send" =>
   	Group "no_block_send": [OK]
   Testing group "block_send" =>
   	Group "block_send": [OK]
   Testing group "no_block_recv" =>
   	Group "no_block_recv": [OK]
   Testing group "block_recv" =>
   	[TEST ASSERT FAILED!]
   		In function "no_block_connect":
   		line 223: Assertion `(ssize_t)((usrsocktest_daemon_get_num_connected_sockets())) == (ssize_t)((1))' failed.
   			got value: 0
   			should be: 1
   	Group "block_recv": [FAILED]
   Testing group "remote_disconnect" =>
   	Group "remote_disconnect": [OK]
   Testing group "basic_setsockopt" =>
   	Group "basic_setsockopt": [OK]
   Testing group "basic_getsockopt" =>
   	Group "basic_getsockopt": [OK]
   Testing group "basic_getsockname" =>
   	Group "basic_getsockname": [OK]
   Testing group "wake_with_signal" =>
   	Group "wake_with_signal": [OK]
   Testing group "multithread" =>
   	Group "multithread": [OK]
   Unit-test groups done... OK:16, FAILED:1, TOTAL:17
    -- number of checks made: 3352
   HEAP BEFORE TESTS:
                total       used       free    largest
   Mem:      67108368     283760   66824608   66824544
   HEAP AFTER TESTS:
                total       used       free    largest
   Mem:      67108368     624080   66484288   66482432
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #7291: usrsock: Correct some status exceptions in non-blocking mode usrsock connect

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #7291:
URL: https://github.com/apache/incubator-nuttx/pull/7291#issuecomment-1278430283

   This PR works now with https://github.com/apache/incubator-nuttx-apps/pull/1345
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] zhhyu7 commented on pull request #7291: usrsock: Correct some status exceptions in non-blocking mode usrsock connect

Posted by GitBox <gi...@apache.org>.
zhhyu7 commented on PR #7291:
URL: https://github.com/apache/incubator-nuttx/pull/7291#issuecomment-1275963272

   
   
   
   
   > @zhhyu7
   > 
   > Please test before sending PR.
   > 
   > ```
   > NuttShell (NSH) NuttX-10.3.0-RC0
   > nsh> uname -a
   > NuttX  10.3.0-RC0 2861124366-dirty Oct 12 2022 19:36:41 sim sim
   > nsh> usrsocktest
   > Starting unit-tests...
   > Testing group "char_dev" =>
   > 	Group "char_dev": [OK]
   > Testing group "no_daemon" =>
   > 	Group "no_daemon": [OK]
   > Testing group "basic_daemon" =>
   > 	Group "basic_daemon": [OK]
   > Testing group "basic_connect" =>
   > 	Group "basic_connect": [OK]
   > Testing group "basic_connect_delay" =>
   > 	Group "basic_connect_delay": [OK]
   > Testing group "no_block_connect" =>
   > 	Group "no_block_connect": [OK]
   > Testing group "basic_send" =>
   > 	Group "basic_send": [OK]
   > Testing group "no_block_send" =>
   > 	Group "no_block_send": [OK]
   > Testing group "block_send" =>
   > 	Group "block_send": [OK]
   > Testing group "no_block_recv" =>
   > 	Group "no_block_recv": [OK]
   > Testing group "block_recv" =>
   > 	[TEST ASSERT FAILED!]
   > 		In function "no_block_connect":
   > 		line 223: Assertion `(ssize_t)((usrsocktest_daemon_get_num_connected_sockets())) == (ssize_t)((1))' failed.
   > 			got value: 0
   > 			should be: 1
   > 	Group "block_recv": [FAILED]
   > Testing group "remote_disconnect" =>
   > 	Group "remote_disconnect": [OK]
   > Testing group "basic_setsockopt" =>
   > 	Group "basic_setsockopt": [OK]
   > Testing group "basic_getsockopt" =>
   > 	Group "basic_getsockopt": [OK]
   > Testing group "basic_getsockname" =>
   > 	Group "basic_getsockname": [OK]
   > Testing group "wake_with_signal" =>
   > 	Group "wake_with_signal": [OK]
   > Testing group "multithread" =>
   > 	Group "multithread": [OK]
   > Unit-test groups done... OK:16, FAILED:1, TOTAL:17
   >  -- number of checks made: 3352
   > HEAP BEFORE TESTS:
   >              total       used       free    largest
   > Mem:      67108368     283760   66824608   66824544
   > HEAP AFTER TESTS:
   >              total       used       free    largest
   > Mem:      67108368     624080   66484288   66482432
   > ```
   
   OK, I will check it. thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] masayuki2009 merged pull request #7291: usrsock: Correct some status exceptions in non-blocking mode usrsock connect

Posted by GitBox <gi...@apache.org>.
masayuki2009 merged PR #7291:
URL: https://github.com/apache/incubator-nuttx/pull/7291


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org