You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by David North <dn...@apache.org> on 2016/09/17 17:07:42 UTC

[VOTE] Apache POI 3.15 RC3

Hi everyone,

https://dist.apache.org/repos/dist/dev/poi/3.15-RC3/

Areas to review:

* Does it work?
* Are the sigs and hashes valid?
* Have the issues with the last RC been fixed?
* Are the release notes (inc requested additions from Javen) OK?

The vote starts now and ends at 18:15 BST on Monday, 21 September.

Here is my +1.

Thanks,

-- 
David North | www.dnorth.net


Re: [VOTE] Apache POI 3.15 RC3

Posted by Javen O'Neal <ja...@gmail.com>.
When I got OOM's with POI because of insufficient heap size, I would
get them when I called wb.write(FileOutputStream).
IIRC I was using POI 3.8 and 3.9 when doing this memory testing.

On Sun, Sep 18, 2016 at 9:54 AM, Dominik Stadler <do...@gmx.at> wrote:
> Hi,
>
> As far as I see it only reduces the amount of memory held while the file
> was open, closing correctly already freed up the memory in previous
> versions as well. It also only was visible with read-only access as then we
> do not use memory-mapping. The user seems to have a very large file at some
> point which consumes lots of memory during reading the content and thus the
> memory usage spiked considerably here.
>
> I think we introduced File Backed Data Source in the mainstream via the
> switch to NPOIFS and the actual memory usage later on with a fix for an
> actual memory leak in NIO Java classes where we needed to put in a
> workaround to release memory.
>
> Not sure if it is worthwhile to mention in the release notes as we did not
> do any measurements of actual effect.
>
> Dominik.
>
> On Sat, Sep 17, 2016 at 7:30 PM, Javen O'Neal <ja...@gmail.com> wrote:
>
>> Is this memory savings seen during regular use of POI, such as the
>> following example, or only when explicitly created with user code calling
>> lower level OPCPackage operations? If so, should release notes mention the
>> lower memory usage for OOXML documents due to File Backed Data Source?
>>
>> Workbook wb = WorkbookFactory.open(file);
>> // Do some things to workbook
>> OutputStrem out = new FileOutputStream(outfile);
>> wb.write(out):
>> wb.close();
>> out.close();
>>
>> On Sep 17, 2016 10:07, "David North" <dn...@apache.org> wrote:
>>
>> > Hi everyone,
>> >
>> > https://dist.apache.org/repos/dist/dev/poi/3.15-RC3/
>> >
>> > Areas to review:
>> >
>> > * Does it work?
>> > * Are the sigs and hashes valid?
>> > * Have the issues with the last RC been fixed?
>> > * Are the release notes (inc requested additions from Javen) OK?
>> >
>> > The vote starts now and ends at 18:15 BST on Monday, 21 September.
>> >
>> > Here is my +1.
>> >
>> > Thanks,
>> >
>> > --
>> > David North | www.dnorth.net
>> >
>> >
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Re: [VOTE] Apache POI 3.15 RC3

Posted by Dominik Stadler <do...@gmx.at>.
Hi,

As far as I see it only reduces the amount of memory held while the file
was open, closing correctly already freed up the memory in previous
versions as well. It also only was visible with read-only access as then we
do not use memory-mapping. The user seems to have a very large file at some
point which consumes lots of memory during reading the content and thus the
memory usage spiked considerably here.

I think we introduced File Backed Data Source in the mainstream via the
switch to NPOIFS and the actual memory usage later on with a fix for an
actual memory leak in NIO Java classes where we needed to put in a
workaround to release memory.

Not sure if it is worthwhile to mention in the release notes as we did not
do any measurements of actual effect.

Dominik.

On Sat, Sep 17, 2016 at 7:30 PM, Javen O'Neal <ja...@gmail.com> wrote:

> Is this memory savings seen during regular use of POI, such as the
> following example, or only when explicitly created with user code calling
> lower level OPCPackage operations? If so, should release notes mention the
> lower memory usage for OOXML documents due to File Backed Data Source?
>
> Workbook wb = WorkbookFactory.open(file);
> // Do some things to workbook
> OutputStrem out = new FileOutputStream(outfile);
> wb.write(out):
> wb.close();
> out.close();
>
> On Sep 17, 2016 10:07, "David North" <dn...@apache.org> wrote:
>
> > Hi everyone,
> >
> > https://dist.apache.org/repos/dist/dev/poi/3.15-RC3/
> >
> > Areas to review:
> >
> > * Does it work?
> > * Are the sigs and hashes valid?
> > * Have the issues with the last RC been fixed?
> > * Are the release notes (inc requested additions from Javen) OK?
> >
> > The vote starts now and ends at 18:15 BST on Monday, 21 September.
> >
> > Here is my +1.
> >
> > Thanks,
> >
> > --
> > David North | www.dnorth.net
> >
> >
>

Re: [VOTE] Apache POI 3.15 RC3

Posted by Javen O'Neal <ja...@gmail.com>.
Is this memory savings seen during regular use of POI, such as the
following example, or only when explicitly created with user code calling
lower level OPCPackage operations? If so, should release notes mention the
lower memory usage for OOXML documents due to File Backed Data Source?

Workbook wb = WorkbookFactory.open(file);
// Do some things to workbook
OutputStrem out = new FileOutputStream(outfile);
wb.write(out):
wb.close();
out.close();

On Sep 17, 2016 10:07, "David North" <dn...@apache.org> wrote:

> Hi everyone,
>
> https://dist.apache.org/repos/dist/dev/poi/3.15-RC3/
>
> Areas to review:
>
> * Does it work?
> * Are the sigs and hashes valid?
> * Have the issues with the last RC been fixed?
> * Are the release notes (inc requested additions from Javen) OK?
>
> The vote starts now and ends at 18:15 BST on Monday, 21 September.
>
> Here is my +1.
>
> Thanks,
>
> --
> David North | www.dnorth.net
>
>

Re: [VOTE] Apache POI 3.15 RC3

Posted by Dominik Stadler <do...@gmx.at>.
I did my usual tests of comparing release-content and running the newer
jars with my local projects, this time all worked fine for me, so I am
finally

+1

Thanks... Dominik.

On Sat, Sep 17, 2016 at 7:07 PM, David North <dn...@apache.org> wrote:

> Hi everyone,
>
> https://dist.apache.org/repos/dist/dev/poi/3.15-RC3/
>
> Areas to review:
>
> * Does it work?
> * Are the sigs and hashes valid?
> * Have the issues with the last RC been fixed?
> * Are the release notes (inc requested additions from Javen) OK?
>
> The vote starts now and ends at 18:15 BST on Monday, 21 September.
>
> Here is my +1.
>
> Thanks,
>
> --
> David North | www.dnorth.net
>
>

Re: [VOTE] Apache POI 3.15 RC3

Posted by Nick Burch <ap...@gagravarr.org>.
On Wed, 21 Sep 2016, David North wrote:
> Nick - please can you sort the Bugzilla versions?

Added 3.15-FINAL and 3.16-dev

3.14-dev and 3.11-FINAL disabled for new bugs

Nick

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Re: [VOTE] Apache POI 3.15 RC3

Posted by David North <dn...@apache.org>.
Just waiting for it to roll out to the mirrors, then I'll send the
announce and sort the website.

Nick - please can you sort the Bugzilla versions?

Thanks,
David

On 21/09/16 07:21, David North wrote:
> +1 = 5
> 
> No 0, no -1
> 
> Accordingly, I will now release 3.15. Thanks everyone.
> 
> On 20/09/16 13:24, David North wrote:
>> Thanks all. I'll do the tally and final actions tonight with a bit of luck.
>>
>> On 20/09/16 02:47, Javen O'Neal wrote:
>>> +1 from me.
>>>
>>> Initiate countdown sequence. 10... 9... 8...
>>>
>>> On Sep 19, 2016 07:50, "Allison, Timothy B." <ta...@mitre.org> wrote:
>>>
>>>> +1
>>>>
>>>> Built on Windows and integrated successfully with Tika and Tika's unit
>>>> tests.  I'm relying on my earlier run of RC2 on the full regression corpus
>>>> as evidence that we're in good shape.
>>>>
>>>> Thank you, David!
>>>>
>>>> Cheers,
>>>>
>>>>             Tim
>>>>
>>>> -----Original Message-----
>>>> From: David North [mailto:dnorth@apache.org]
>>>> Sent: Saturday, September 17, 2016 1:08 PM
>>>> To: POI Developers List <de...@poi.apache.org>
>>>> Subject: [VOTE] Apache POI 3.15 RC3
>>>>
>>>> Hi everyone,
>>>>
>>>> https://dist.apache.org/repos/dist/dev/poi/3.15-RC3/
>>>>
>>>> Areas to review:
>>>>
>>>> * Does it work?
>>>> * Are the sigs and hashes valid?
>>>> * Have the issues with the last RC been fixed?
>>>> * Are the release notes (inc requested additions from Javen) OK?
>>>>
>>>> The vote starts now and ends at 18:15 BST on Monday, 21 September.
>>>>
>>>> Here is my +1.
>>>>
>>>> Thanks,
>>>>
>>>> --
>>>> David North | www.dnorth.net
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
>>>> For additional commands, e-mail: dev-help@poi.apache.org
>>>>
>>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
>> For additional commands, e-mail: dev-help@poi.apache.org
>>
> 

-- 
David North | www.dnorth.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Re: [VOTE] Apache POI 3.15 RC3

Posted by David North <dn...@apache.org>.
+1 = 5

No 0, no -1

Accordingly, I will now release 3.15. Thanks everyone.

On 20/09/16 13:24, David North wrote:
> Thanks all. I'll do the tally and final actions tonight with a bit of luck.
> 
> On 20/09/16 02:47, Javen O'Neal wrote:
>> +1 from me.
>>
>> Initiate countdown sequence. 10... 9... 8...
>>
>> On Sep 19, 2016 07:50, "Allison, Timothy B." <ta...@mitre.org> wrote:
>>
>>> +1
>>>
>>> Built on Windows and integrated successfully with Tika and Tika's unit
>>> tests.  I'm relying on my earlier run of RC2 on the full regression corpus
>>> as evidence that we're in good shape.
>>>
>>> Thank you, David!
>>>
>>> Cheers,
>>>
>>>             Tim
>>>
>>> -----Original Message-----
>>> From: David North [mailto:dnorth@apache.org]
>>> Sent: Saturday, September 17, 2016 1:08 PM
>>> To: POI Developers List <de...@poi.apache.org>
>>> Subject: [VOTE] Apache POI 3.15 RC3
>>>
>>> Hi everyone,
>>>
>>> https://dist.apache.org/repos/dist/dev/poi/3.15-RC3/
>>>
>>> Areas to review:
>>>
>>> * Does it work?
>>> * Are the sigs and hashes valid?
>>> * Have the issues with the last RC been fixed?
>>> * Are the release notes (inc requested additions from Javen) OK?
>>>
>>> The vote starts now and ends at 18:15 BST on Monday, 21 September.
>>>
>>> Here is my +1.
>>>
>>> Thanks,
>>>
>>> --
>>> David North | www.dnorth.net
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
>>> For additional commands, e-mail: dev-help@poi.apache.org
>>>
>>>
>>
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
> 

-- 
David North | www.dnorth.net


Re: [VOTE] Apache POI 3.15 RC3

Posted by David North <dt...@corefiling.co.uk>.
Thanks all. I'll do the tally and final actions tonight with a bit of luck.

On 20/09/16 02:47, Javen O'Neal wrote:
> +1 from me.
> 
> Initiate countdown sequence. 10... 9... 8...
> 
> On Sep 19, 2016 07:50, "Allison, Timothy B." <ta...@mitre.org> wrote:
> 
>> +1
>>
>> Built on Windows and integrated successfully with Tika and Tika's unit
>> tests.  I'm relying on my earlier run of RC2 on the full regression corpus
>> as evidence that we're in good shape.
>>
>> Thank you, David!
>>
>> Cheers,
>>
>>             Tim
>>
>> -----Original Message-----
>> From: David North [mailto:dnorth@apache.org]
>> Sent: Saturday, September 17, 2016 1:08 PM
>> To: POI Developers List <de...@poi.apache.org>
>> Subject: [VOTE] Apache POI 3.15 RC3
>>
>> Hi everyone,
>>
>> https://dist.apache.org/repos/dist/dev/poi/3.15-RC3/
>>
>> Areas to review:
>>
>> * Does it work?
>> * Are the sigs and hashes valid?
>> * Have the issues with the last RC been fixed?
>> * Are the release notes (inc requested additions from Javen) OK?
>>
>> The vote starts now and ends at 18:15 BST on Monday, 21 September.
>>
>> Here is my +1.
>>
>> Thanks,
>>
>> --
>> David North | www.dnorth.net
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
>> For additional commands, e-mail: dev-help@poi.apache.org
>>
>>
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


RE: [VOTE] Apache POI 3.15 RC3

Posted by Javen O'Neal <ja...@gmail.com>.
+1 from me.

Initiate countdown sequence. 10... 9... 8...

On Sep 19, 2016 07:50, "Allison, Timothy B." <ta...@mitre.org> wrote:

> +1
>
> Built on Windows and integrated successfully with Tika and Tika's unit
> tests.  I'm relying on my earlier run of RC2 on the full regression corpus
> as evidence that we're in good shape.
>
> Thank you, David!
>
> Cheers,
>
>             Tim
>
> -----Original Message-----
> From: David North [mailto:dnorth@apache.org]
> Sent: Saturday, September 17, 2016 1:08 PM
> To: POI Developers List <de...@poi.apache.org>
> Subject: [VOTE] Apache POI 3.15 RC3
>
> Hi everyone,
>
> https://dist.apache.org/repos/dist/dev/poi/3.15-RC3/
>
> Areas to review:
>
> * Does it work?
> * Are the sigs and hashes valid?
> * Have the issues with the last RC been fixed?
> * Are the release notes (inc requested additions from Javen) OK?
>
> The vote starts now and ends at 18:15 BST on Monday, 21 September.
>
> Here is my +1.
>
> Thanks,
>
> --
> David North | www.dnorth.net
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
>

RE: [VOTE] Apache POI 3.15 RC3

Posted by "Allison, Timothy B." <ta...@mitre.org>.
+1

Built on Windows and integrated successfully with Tika and Tika's unit tests.  I'm relying on my earlier run of RC2 on the full regression corpus as evidence that we're in good shape.

Thank you, David!

Cheers,

            Tim

-----Original Message-----
From: David North [mailto:dnorth@apache.org] 
Sent: Saturday, September 17, 2016 1:08 PM
To: POI Developers List <de...@poi.apache.org>
Subject: [VOTE] Apache POI 3.15 RC3

Hi everyone,

https://dist.apache.org/repos/dist/dev/poi/3.15-RC3/

Areas to review:

* Does it work?
* Are the sigs and hashes valid?
* Have the issues with the last RC been fixed?
* Are the release notes (inc requested additions from Javen) OK?

The vote starts now and ends at 18:15 BST on Monday, 21 September.

Here is my +1.

Thanks,

-- 
David North | www.dnorth.net


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Re: [VOTE] Apache POI 3.15 RC3

Posted by Andreas Beeker <ki...@apache.org>.
+1

Sigs and docs look ok.
As this is a final release, please also add a note pointing to #59170 in the release notes.
FYI, I've removed the obsolete nexus repos.

Andi



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org