You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2021/10/22 14:00:27 UTC
[GitHub] [drill] rymarm commented on a change in pull request #2333: DRILL-8009: DrillConnectionImpl#isValid() doesn't correspond JDBC API
rymarm commented on a change in pull request #2333:
URL: https://github.com/apache/drill/pull/2333#discussion_r734568806
##########
File path: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java
##########
@@ -520,8 +520,12 @@ public SQLXML createSQLXML() throws SQLException {
@Override
public boolean isValid(int timeout) throws SQLException {
- checkOpen();
- return super.isValid(timeout);
+ if (timeout < 0) {
Review comment:
We could be nicer, but there are [requirements](https://docs.oracle.com/javase/8/docs/api/java/sql/Connection.html#isValid-int-) of JDBC interface:
> https://docs.oracle.com/javase/8/docs/api/java/sql/Connection.html#isValid-int-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org