You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@labs.apache.org by ry...@apache.org on 2008/10/13 23:28:18 UTC

svn commit: r704257 - /labs/droids/branch/LABS-144/src/core/java/org/apache/droids/helper/factories/HandlerFactory.java

Author: ryan
Date: Mon Oct 13 14:28:18 2008
New Revision: 704257

URL: http://svn.apache.org/viewvc?rev=704257&view=rev
Log:
simplify loop logic (use java 5 style)

Modified:
    labs/droids/branch/LABS-144/src/core/java/org/apache/droids/helper/factories/HandlerFactory.java

Modified: labs/droids/branch/LABS-144/src/core/java/org/apache/droids/helper/factories/HandlerFactory.java
URL: http://svn.apache.org/viewvc/labs/droids/branch/LABS-144/src/core/java/org/apache/droids/helper/factories/HandlerFactory.java?rev=704257&r1=704256&r2=704257&view=diff
==============================================================================
--- labs/droids/branch/LABS-144/src/core/java/org/apache/droids/helper/factories/HandlerFactory.java (original)
+++ labs/droids/branch/LABS-144/src/core/java/org/apache/droids/helper/factories/HandlerFactory.java Mon Oct 13 14:28:18 2008
@@ -21,7 +21,6 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.net.URL;
-import java.util.Iterator;
 
 import org.apache.commons.io.IOUtils;
 import org.apache.droids.api.Handler;
@@ -59,16 +58,15 @@
     } catch (IOException e) {
       log.fatal("Handler setup has thrown an error.", e);
     }
-    for (Iterator<String> iterator = getMap().keySet().iterator(); iterator.hasNext();) {
-      String handlerName = iterator.next();
+    
+    for (Handler handler : getMap().values()) {
       if (streamCopy == null) {
         return false;
       }
-      Handler handler = getMap().get(handlerName);
       try {
         handler.handle(new ByteArrayInputStream(streamCopy), url, parse);
       } catch (Exception e) {
-        log.fatal("Handler \"" + handlerName + "\" has thrown an error.", e);
+        log.fatal("Handler \"" + handler + "\" has thrown an error.", e);
       }
     }
     return true;



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@labs.apache.org
For additional commands, e-mail: commits-help@labs.apache.org