You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/27 08:24:35 UTC
[GitHub] [superset] hbruch opened a new pull request #17877: fix(translation): include babel-compile in Dockerfile (#17876)
hbruch opened a new pull request #17877:
URL: https://github.com/apache/superset/pull/17877
### SUMMARY
Adds babel-compile step in Dockerfile.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
<img width="1672" alt="image" src="https://user-images.githubusercontent.com/2187389/147451376-46d4976e-514c-4142-97e5-8e46500c618f.png">
### TESTING INSTRUCTIONS
1. Enable a rather complete language in superset_config_docker.py:
```
BABEL_DEFAULT_LOCALE = "de"
LANGUAGES = {
"de": {"flag": "de", "name": "Deutsch"},
"en": {"flag": "us", "name": "English"},
}
```
2. build docker images via `docker build -t apache/superset:latest-dev .`
3. Start superset via `docker-compose -f docker-compose-non-dev.yml' p -d`
4. Open http://localhost:8088/
5. See formerly untranslated messages now translated
### ADDITIONAL INFORMATION
- [x] Has associated issue: Fixes #17876
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #17877: fix(translation): include babel-compile in Dockerfile (#17876)
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #17877:
URL: https://github.com/apache/superset/pull/17877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hbruch commented on pull request #17877: fix(translation): include babel-compile in Dockerfile (#17876)
Posted by GitBox <gi...@apache.org>.
hbruch commented on pull request #17877:
URL: https://github.com/apache/superset/pull/17877#issuecomment-1002693238
@villebro Seems like there was a temporay problem with git checkout (?) Could you restart the checks (or could I do this myself?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org