You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/07/13 13:01:28 UTC
[GitHub] [lucene-solr] ErickErickson opened a new pull request #1668: SOLR-13939: Extract any non-gradle related patches (deprecations, URL…
ErickErickson opened a new pull request #1668:
URL: https://github.com/apache/lucene-solr/pull/1668
These are the thread leak changes from some work Mark Miller did quite a while ago. "gradlew check" passes, BUT I haven't examined the changes at all, I wanted to make it available ASAP for people to look at.
I don't even know if the approach _should_ be pushed. I've just mechanically grouped all the related changes in order to get a well-defined unit to examine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] ErickErickson commented on pull request #1668: SOLR-13939: Extract any non-gradle related patches (deprecations, URL…
Posted by GitBox <gi...@apache.org>.
ErickErickson commented on pull request #1668:
URL: https://github.com/apache/lucene-solr/pull/1668#issuecomment-657811914
@risdenk Thanks for looking. This is more about adding thread leak detection to a bunch of classes. When Mark was working on Gradle, a lot of other stuff was changed that weren't strictly related to changing the build system and this JIRA is just about taking any of those changes and making them their own.
Looking over some recent changes, I doubt this'll really cut down on the number of failures due to thread leak detection. OTOH, I don't see any harm in it.
On the other other hand, I have to check inheritance. SolrIgnoredThreadsFilter is included in SolrTestCase, so IDK whether it's necessary to include it in anything that inherits from it... Siiiggghhh.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] ErickErickson closed pull request #1668: SOLR-13939: Extract any non-gradle related patches (deprecations, URL…
Posted by GitBox <gi...@apache.org>.
ErickErickson closed pull request #1668:
URL: https://github.com/apache/lucene-solr/pull/1668
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org